Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve logging around lifecycle scripts #420

Merged
merged 3 commits into from
Nov 22, 2024
Merged

chore: improve logging around lifecycle scripts #420

merged 3 commits into from
Nov 22, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 22, 2024 •
edited
Loading

Closes #418

  • Adds improved logging around lifecycle scripts and whether we're building from a devcontainer.json or a Dockerfile
  • Improves integration tests around lifecycle script execution

@johnstcn johnstcn self-assigned this Nov 22, 2024
mafredri
mafredri approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V nice!

envbuilder.go Show resolved Hide resolved
envbuilder.go Outdated Show resolved Hide resolved
envbuilder.go Outdated Show resolved Hide resolved
@johnstcn johnstcn merged commit fafad44 into main Nov 22, 2024
4 checks passed
@johnstcn johnstcn deleted the cj/lifecycle-scripts-logging branch November 22, 2024 13:09
johnstcn added a commit that referenced this pull request Nov 25, 2024
@johnstcn
chore: improve logging around lifecycle scripts (#420)
7cb6b0a 
(cherry picked from commit fafad44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

@SasSwart SasSwart Awaiting requested review from SasSwart

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add improved logging around devcontainer.json lifecycle commands
2 participants
@johnstcn @mafredri