Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script test workflow triggers #4412

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fix script test workflow triggers #4412

merged 1 commit into from
Oct 29, 2021

Conversation

code-asher
Copy link
Member

No description provided.

@code-asher code-asher requested a review from a team as a code owner October 28, 2021 21:42
@code-asher code-asher marked this pull request as draft October 28, 2021 21:43
jawnsy
jawnsy approved these changes Oct 28, 2021
View reviewed changes
.github/workflows/scripts.yml Show resolved Hide resolved
@code-asher code-asher force-pushed the fix-test-triggers branch 2 times, most recently from 8b27b81 to d3af695 Compare October 29, 2021 18:07
@codecov
Copy link

codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #4412 (d3af695) into main (705e821) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4412   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files          31       31           
  Lines        1619     1619           
  Branches      316      316           
=======================================
  Hits         1072     1072           
  Misses        469      469           
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705e821...d3af695. Read the comment docs.

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 29, 2021

Is this PR ready for review? (re-running jobs since something 404'd)

@code-asher
Copy link
Member Author

code-asher commented Oct 29, 2021 •
edited
Loading

Yeah I re-ran it once but it is failing to download the build artifact for some reason...hopefully it works this time.

@code-asher code-asher marked this pull request as ready for review October 29, 2021 19:18
jsjoeio
jsjoeio approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@code-asher code-asher merged commit 49c9c19 into coder:main Oct 29, 2021
@code-asher code-asher deleted the fix-test-triggers branch October 29, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@jawnsy jawnsy jawnsy approved these changes

Assignees

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@code-asher @jsjoeio @jawnsy