Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No file encoding button display #1437

Closed
xiaoyun94 opened this issue Mar 21, 2020 · 9 comments
Closed

No file encoding button display #1437

xiaoyun94 opened this issue Mar 21, 2020 · 9 comments
Labels
blocked This issue cannot proceed due to external factors bug Something isn't working upstream Needs to be fixed upstream

Comments

@xiaoyun94
Copy link

xiaoyun94 commented Mar 21, 2020

VS code has a button at the bottom to switch file encode type, such as gbk, utf8, but it does not show up tn code server. i have tried in my os deepin 15.10, open suse 15.1, suse server 12 sp3, all of them were missing this func. but i found ur shortcuts have this button, so i am wondering why this func is missing in my OSs.

@xiaoyun94
Copy link
Author

xiaoyun94 commented Mar 21, 2020

V3&V2 matters.
V1 works well

@kylecarbs
Copy link
Member

Thanks for the report. We should definitely support multiple file-encoding types.

@gnouts
Copy link

gnouts commented Apr 3, 2020

This is a blocker for me.
If I try to use v1 I'm stuck with this bug #338
And v2 and v3 don't offer to change encoding.
I try changing the settings.json with "files.encoding": "windows1252" but it doesn't seem to do anything.
Is there a workaround to change encoding ? (I really need to open files with special char like ¤ )

@code-asher
Copy link
Member

code-asher commented Apr 7, 2020

@kylecarbs
Copy link
Member

kylecarbs commented Apr 9, 2020

@gnouts sorry to hear. We can definitely fix this if enough interest arises. For now, unfortunately it's a pretty low-priority issue.

Feel free to take a stab at it though, we'd happily merge your contribution :)

@nhooyr nhooyr added blocked This issue cannot proceed due to external factors upstream Needs to be fixed upstream bug Something isn't working and removed needs-investigation labels Apr 17, 2020
@xiaoyun94
Copy link
Author

a sad story for Chinese developers

@Shagrat2
Copy link

Shagrat2 commented May 8, 2020

UTF-8 open as Layout U.S. and kill not english chars

@gyzerok
Copy link

gyzerok commented May 12, 2020

I'd like to contribute to this issue by specifying my use-case, so you can keep it in mind once it gets unblocked.

I need to be able to specify encoding on a per-language basis.

@nhooyr
Copy link
Contributor

nhooyr commented May 14, 2020

Duplicate of #1017

@nhooyr nhooyr marked this as a duplicate of #1017 May 14, 2020
@nhooyr nhooyr closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue cannot proceed due to external factors bug Something isn't working upstream Needs to be fixed upstream
Projects
None yet
Development

No branches or pull requests

7 participants