Skip to content

Commit

Permalink
fix(ci): temporarily disable install deps from cache
Browse files Browse the repository at this point in the history
  • Loading branch information
jsjoeio committed Oct 1, 2021
1 parent eb77c7d commit fb7fd50
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 9 deletions.
20 changes: 12 additions & 8 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,18 @@ jobs:
- name: Install helm
uses: azure/[email protected]

- name: Fetch dependencies from cache
id: cache-yarn
uses: actions/cache@v2
with:
path: "**/node_modules"
key: yarn-build-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
yarn-build-
# NOTE@jsjoeio
# disabling this until we can audit the build process
# and the usefulness of this step
# See: https://github.com/cdr/code-server/issues/4287
# - name: Fetch dependencies from cache
# id: cache-yarn
# uses: actions/cache@v2
# with:
# path: "**/node_modules"
# key: yarn-build-${{ hashFiles('**/yarn.lock') }}
# restore-keys: |
# yarn-build-

- name: Install dependencies
# if: steps.cache-yarn.outputs.cache-hit != 'true'
Expand Down
2 changes: 1 addition & 1 deletion src/node/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ export const shouldRunVsCodeCli = (args: Args): boolean => {
/**
* Reads the socketPath based on path passed in.
*
* The one usually pased in is the DEFAULT_SOCKET_PATH.
* The one usually passed in is the DEFAULT_SOCKET_PATH.
*
* If it can't read the path, it throws an error and returns undefined.
*/
Expand Down

0 comments on commit fb7fd50

Please sign in to comment.