Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phantomjs is an unmaintained project #5931

Closed
ossdev07 opened this issue Jul 9, 2019 · 3 comments
Closed

phantomjs is an unmaintained project #5931

ossdev07 opened this issue Jul 9, 2019 · 3 comments

Comments

@ossdev07
Copy link
Contributor

ossdev07 commented Jul 9, 2019

Hello Team,

PhantomJS is an unmaintained project and CodeMirror uses phantomjs for its qunit testing.

I am curious to know that will you be interested in replacing phantomjs with some other suitable alternative, as it is better using up to date dependencies.

Please share your thoughts on this and any further suggestion regarding the phantomjs replacement like chrome headless.

@ossdev07
Copy link
Contributor Author

ossdev07 commented Sep 3, 2019

Ping @marijnh

I would like to introduce puppeteer as the testing framework in replacement to phantomjs,
As in order to achieve the same, I would have to update the test cases and other files having phantomjs support currently.
Will you be interested in accepting such a wide change in the package, could you please share your feedback on this.

@marijnh
Copy link
Member

marijnh commented Sep 3, 2019

What would you need to change about the tests themselves? There's some feature-detection happening where tests that don't run properly on Phantom are turned off, but I think that would be it (and can be ignored in a first iteration and removed later).

I'd be interested in a Puppeteer-based test runner. There's a bunch of tests that fail on current Chrome due to some details of the way it handles bidi text changing between the ancient version in PhantomJS and current versions, but I'm okay with just disabling those until someone has time to look into them.

@marijnh
Copy link
Member

marijnh commented Nov 5, 2019

Closed via #6051

@marijnh marijnh closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants