Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command to manage users #566

Closed
robertogerola opened this issue Dec 21, 2022 · 7 comments · Fixed by #833
Closed

CLI command to manage users #566

robertogerola opened this issue Dec 21, 2022 · 7 comments · Fixed by #833
Labels
new feature PRs for new features

Comments

@robertogerola
Copy link
Contributor

Hello. I wrote a command to manage users from CLI : create, activate, deactivate, change name, change email, set password

Here my last commit :
https://github.com/robertogerola/shield/commit/ab09040c4a14c4ebbc2f3e91e3aef3b329662291

I'm still working on it. I need to add group assignment feature.
If you think it could be useful also for others I can submit a PR in the coming days.

@kenjis
Copy link
Member

kenjis commented Dec 22, 2022

I think the command is very useful for many users.
It would be great if Shield has the command.

@lonnieezell
Copy link
Member

I agree. I would love to see it included.

@robertogerola
Copy link
Contributor Author

Thanks for the positive feedback, PR submitted #567.

@robertogerola
Copy link
Contributor Author

I think I fixed the mess I created with my previous PR. I wasn't able to remove the merge commits, so I created a new clean PR : #568
I'm sorry, these are my first steps with Github, I'm still learning !

@datamweb
Copy link
Collaborator

@robertogerola Don't worry, we've all been in the same situation as you. I guided you in #568 .
If you haven't received feedback yet, it's because of prioritization of tasks, not your performance. So go ahead.

@lonnieezell
Copy link
Member

@robertogerola What happened to the previous PR? I'm looking forward to this command :)

@robertogerola
Copy link
Contributor Author

robertogerola commented Jan 2, 2023

@lonnieezell Hi, my previous PR contained a lot of errors : merge commits, not signed commits, a lot of styling issues, not a specific branch on my side. I removed the previous PR and create a new clean one. Hope everything is fine this time ;-). Here the new shiny PR #579 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature PRs for new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants