Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System path incorrect #1

Closed
MGatner opened this issue May 22, 2019 · 5 comments
Closed

System path incorrect #1

MGatner opened this issue May 22, 2019 · 5 comments

Comments

@MGatner
Copy link
Member

MGatner commented May 22, 2019

I thought I'd try switching one of my 4.0.0-beta3 apps over to the dev branch so I'd have something to test on with the latest changes. After firing this up based on the user docs (composer create-project codeigniter4/devstarter -s dev) I found that it wasn't working. First issue is that $systemDirectory is pointing at where it should be for the AppStarter (vendor/codeigniter4/framework) instead of for the VCS-defined repo (vendor/codeigniter4/codeigniter4). This appears to be a file that is synced with AppStarter so I'm not sure how to go about excluding it, but the actual change is minor.

EDIT: Should have specified, $systemDirectory in app/Config/Paths.php

@MGatner
Copy link
Member Author

MGatner commented Aug 13, 2019

I believe this is still valid.

@jim-parry
Copy link
Contributor

See comment for closed PR

@MGatner
Copy link
Member Author

MGatner commented Aug 13, 2019

The issue is that both appstarter and devstarter are receiving the same Config/Paths.php, but the former uses the released framework as a dependency (codeginiter4/framework) and the latter uses the development repo directly (codeigniter4/codeigniter4). I suspect it will take some search-and-replace action in admin/release-framework but until it is implemented the devstarter install instructions in the User Guide will create a project that won't run:
composer create-project codeigniter4/devstarter -s dev

@jim-parry
Copy link
Contributor

I have updated app/Config/Paths.php in the devstarter.
That repo isn't "released" the same way the framework and app starter are, but the way the directions are written up, a "composer update" should now fix the incorrect system path.

@MGatner
Copy link
Member Author

MGatner commented Aug 14, 2019

Great! Thank you for addressing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants