Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Toobar Debug CSS + Fix DESIGN #8562

Closed
wants to merge 3 commits into from
Closed

feat: Toobar Debug CSS + Fix DESIGN #8562

wants to merge 3 commits into from

Conversation

ALTITUDE-DEV-FR
Copy link
Contributor

@ALTITUDE-DEV-FR ALTITUDE-DEV-FR commented Feb 19, 2024

Description

An update that adds an HTML debug and modifies some icons, including the hotbar reload and core icons in SVG format. It also includes adding orange color to the SVG icon of the framework upon clicking on an action.

The new debug CSS/HTML show a trait for all html block present in page.

Capture d'écran 2024-02-19 144218

Vidéo : https://www.loom.com/share/d84560b5c5544a2fb7fc883f6f8e36f2

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I'm not sure whether the HTML debug view is something that belongs in the framework, honestly. It's a nice feature but seems like one that people will want to keep adding on top of to make it do more things. As a PHP framework I'm leery to go down the HTML editor route. Seems better as a browser plugin to me.

We will see what the others have to say.

@lonnieezell
Copy link
Member

Maybe it would be better to make the toolbar support addons? Then this functionality could be a community package and could grow to be much larger than we would want to support here.

@kenjis kenjis added wrong branch PRs sent to wrong branch enhancement PRs that improve existing functionalities labels Feb 19, 2024
@kenjis
Copy link
Member

kenjis commented Feb 19, 2024

I don't know if it will be actually used, but I feel it's cool!
However, I think Lonnie is right.

One thing, if you enable CSP, an error occurs:
Screenshot 2024-02-20 6 22 03

@kenjis kenjis changed the title Feat: Toobar Debug CSS + Fix DESIGN feat: Toobar Debug CSS + Fix DESIGN Feb 19, 2024
@ALTITUDE-DEV-FR
Copy link
Contributor Author

ALTITUDE-DEV-FR commented Feb 20, 2024

Hello Thanks for reply's.
Yes sure, @lonnieezell are right.

If ever I corrected the left icons in svg and css image if it can at least be useful ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities wrong branch PRs sent to wrong branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants