Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix the validation with asterisk example #8126

Closed
wants to merge 2 commits into from
Closed

docs: Fix the validation with asterisk example #8126

wants to merge 2 commits into from

Conversation

ping-yee
Copy link
Contributor

Description
See #8079

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Oct 30, 2023
kenjis
kenjis reviewed Oct 30, 2023
View reviewed changes
user_guide_src/source/libraries/validation/009.php
* [
* 'name' => 'Wilma',
* ],
* 'name' => 'Fred Flinstone',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is odd that friends is not an array.
And this data does not match contacts.friends.*.name below.

@kenjis kenjis mentioned this pull request Oct 31, 2023
Merged
5 tasks
@kenjis
Copy link
Member

kenjis commented Oct 31, 2023

@ping-yee I will fix the docs in #8129
Review, please.

@ping-yee
Copy link
Contributor Author

@kenjis Ok. Looks Good and I close this.

@ping-yee ping-yee closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis left review comments

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ping-yee @kenjis