Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DebugBar] dark mode timeline "Controller" #8125

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: [DebugBar] dark mode timeline "Controller" #8125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51391df
fix: cannot see "Controller" row in dark mode
kenjis Oct 30, 2023
e3440d7
docs: update css.md
kenjis Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions admin/css/debug-toolbar/_theme-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@
.timer {
background-color: $g-orange;
}

.timeline-parent-open td {
color: $t-dark;
}
}
}

Expand Down
25 changes: 4 additions & 21 deletions contributing/css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ the official website: <https://sass-lang.com/install>
Open your terminal, and navigate to CodeIgniter's root folder. To
generate the CSS file, use the following command:

`sass --no-source-map admin/css/debug-toolbar/toolbar.scss system/Debug/Toolbar/Views/toolbar.css`
```console
sass --no-source-map admin/css/debug-toolbar/toolbar.scss system/Debug/Toolbar/Views/toolbar.css`
```

Details:
- `--no-source-map` is an option which prevents sourcemap files from being generated
Expand All @@ -18,23 +20,4 @@ Details:

## Color scheme

**Themes**

Dark: `#252525` / `rgb(37, 37, 37)`
Light: `#FFFFFF` / `rgb(255, 255, 255)`

**Glossy colors**

Blue: `#5BC0DE` / `rgb(91, 192, 222)`
Gray: `#434343` / `rgb(67, 67, 67)`
Green: `#9ACE25` / `rgb(154, 206, 37)`
Orange: `#DD8615` / `rgb(221, 134, 21)`
Red: `#DD4814` / `rgb(221, 72, 20)`

**Matt colors**

Blue: `#D8EAF0` / `rgb(216, 234, 240)`
Gray: `#DFDFDF` / `rgb(223, 223, 223)`
Green: `#DFF0D8` / `rgb(223, 240, 216)`
Orange: `#FDC894` / `rgb(253, 200, 148)`
Red: `#EF9090` / `rgb(239, 144, 144)`
See [_graphic-charter.scss](../admin/css/debug-toolbar/_graphic-charter.scss).
6 changes: 0 additions & 6 deletions system/Debug/Toolbar/Views/toolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,9 +532,6 @@
#debug-bar .timeline .timer {
background-color: #DD8615;
}
#debug-bar .timeline .timeline-parent-open td {
color: #252525;
}
.debug-view.show-view {
border-color: #DD8615;
}
Expand Down Expand Up @@ -647,9 +644,6 @@
#toolbarContainer.dark #debug-bar .timeline .timer {
background-color: #DD8615;
}
#toolbarContainer.dark #debug-bar .timeline .timeline-parent-open td {
color: #252525;
}
#toolbarContainer.dark .debug-view.show-view {
border-color: #DD8615;
}
Expand Down