From 25ec3df976ee15096412a9f555f64d6fa2dbc1a7 Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 29 Aug 2022 17:58:52 +0900 Subject: [PATCH 01/11] refactor: add `declare(strict_types=1)` to system files --- system/API/ResponseTrait.php | 2 ++ system/Autoloader/Autoloader.php | 2 ++ system/Autoloader/FileLocator.php | 2 ++ system/Autoloader/FileLocatorCached.php | 2 ++ system/Autoloader/FileLocatorInterface.php | 2 ++ system/BaseModel.php | 2 ++ system/CLI/BaseCommand.php | 2 ++ system/CLI/CLI.php | 2 ++ system/CLI/Commands.php | 2 ++ system/CLI/Console.php | 2 ++ system/CLI/Exceptions/CLIException.php | 2 ++ system/CLI/GeneratorTrait.php | 2 ++ system/Cache/CacheFactory.php | 2 ++ system/Cache/CacheInterface.php | 2 ++ system/Cache/Exceptions/CacheException.php | 2 ++ system/Cache/Exceptions/ExceptionInterface.php | 2 ++ system/Cache/FactoriesCache.php | 2 ++ system/Cache/FactoriesCache/FileVarExportHandler.php | 2 ++ system/Cache/Handlers/BaseHandler.php | 2 ++ system/Cache/Handlers/DummyHandler.php | 2 ++ system/Cache/Handlers/FileHandler.php | 2 ++ system/Cache/Handlers/MemcachedHandler.php | 2 ++ system/Cache/Handlers/PredisHandler.php | 2 ++ system/Cache/Handlers/RedisHandler.php | 2 ++ system/Cache/Handlers/WincacheHandler.php | 2 ++ system/Cache/ResponseCache.php | 2 ++ system/CodeIgniter.php | 2 ++ system/Commands/Cache/ClearCache.php | 2 ++ system/Commands/Cache/InfoCache.php | 2 ++ system/Commands/Database/CreateDatabase.php | 2 ++ system/Commands/Database/Migrate.php | 2 ++ system/Commands/Database/MigrateRefresh.php | 2 ++ system/Commands/Database/MigrateRollback.php | 2 ++ system/Commands/Database/MigrateStatus.php | 2 ++ system/Commands/Database/Seed.php | 2 ++ system/Commands/Database/ShowTableInfo.php | 2 ++ system/Commands/Encryption/GenerateKey.php | 2 ++ system/Commands/Generators/CellGenerator.php | 2 ++ system/Commands/Generators/CommandGenerator.php | 2 ++ system/Commands/Generators/ConfigGenerator.php | 2 ++ system/Commands/Generators/ControllerGenerator.php | 2 ++ system/Commands/Generators/EntityGenerator.php | 2 ++ system/Commands/Generators/FilterGenerator.php | 2 ++ system/Commands/Generators/MigrationGenerator.php | 2 ++ system/Commands/Generators/ModelGenerator.php | 2 ++ system/Commands/Generators/ScaffoldGenerator.php | 2 ++ system/Commands/Generators/SeederGenerator.php | 2 ++ system/Commands/Generators/ValidationGenerator.php | 2 ++ system/Commands/Help.php | 2 ++ system/Commands/Housekeeping/ClearDebugbar.php | 2 ++ system/Commands/Housekeeping/ClearLogs.php | 2 ++ system/Commands/ListCommands.php | 2 ++ system/Commands/Server/Serve.php | 2 ++ system/Commands/Server/rewrite.php | 2 ++ system/Commands/Translation/LocalizationFinder.php | 2 ++ system/Commands/Utilities/Environment.php | 2 ++ system/Commands/Utilities/FilterCheck.php | 2 ++ system/Commands/Utilities/Namespaces.php | 2 ++ system/Commands/Utilities/Publish.php | 2 ++ system/Commands/Utilities/Routes.php | 2 ++ system/Commands/Utilities/Routes/AutoRouteCollector.php | 2 ++ .../Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php | 2 ++ .../Routes/AutoRouterImproved/ControllerMethodReader.php | 2 ++ system/Commands/Utilities/Routes/ControllerFinder.php | 2 ++ system/Commands/Utilities/Routes/ControllerMethodReader.php | 2 ++ system/Commands/Utilities/Routes/FilterCollector.php | 2 ++ system/Commands/Utilities/Routes/FilterFinder.php | 2 ++ system/Commands/Utilities/Routes/SampleURIGenerator.php | 2 ++ system/Common.php | 2 ++ system/ComposerScripts.php | 2 ++ system/Config/AutoloadConfig.php | 2 ++ system/Config/BaseConfig.php | 2 ++ system/Config/BaseService.php | 2 ++ system/Config/DotEnv.php | 2 ++ system/Config/Factories.php | 2 ++ system/Config/Factory.php | 2 ++ system/Config/ForeignCharacters.php | 2 ++ system/Config/Publisher.php | 2 ++ system/Config/Routing.php | 2 ++ system/Config/Services.php | 2 ++ system/Config/View.php | 2 ++ system/Controller.php | 2 ++ system/Cookie/CloneableCookieInterface.php | 2 ++ system/Cookie/Cookie.php | 2 ++ system/Cookie/CookieInterface.php | 2 ++ system/Cookie/CookieStore.php | 2 ++ system/Cookie/Exceptions/CookieException.php | 2 ++ system/Database/BaseBuilder.php | 2 ++ system/Database/BaseConnection.php | 2 ++ system/Database/BasePreparedQuery.php | 2 ++ system/Database/BaseResult.php | 2 ++ system/Database/BaseUtils.php | 2 ++ system/Database/Config.php | 2 ++ system/Database/ConnectionInterface.php | 2 ++ system/Database/Database.php | 2 ++ system/Database/Exceptions/DataException.php | 2 ++ system/Database/Exceptions/DatabaseException.php | 2 ++ system/Database/Exceptions/ExceptionInterface.php | 2 ++ system/Database/Forge.php | 2 ++ system/Database/Migration.php | 2 ++ system/Database/MigrationRunner.php | 2 ++ system/Database/MySQLi/Builder.php | 2 ++ system/Database/MySQLi/Connection.php | 2 ++ system/Database/MySQLi/Forge.php | 2 ++ system/Database/MySQLi/PreparedQuery.php | 2 ++ system/Database/MySQLi/Result.php | 2 ++ system/Database/MySQLi/Utils.php | 2 ++ system/Database/OCI8/Builder.php | 2 ++ system/Database/OCI8/Connection.php | 2 ++ system/Database/OCI8/Forge.php | 2 ++ system/Database/OCI8/PreparedQuery.php | 2 ++ system/Database/OCI8/Result.php | 2 ++ system/Database/OCI8/Utils.php | 2 ++ system/Database/Postgre/Builder.php | 2 ++ system/Database/Postgre/Connection.php | 2 ++ system/Database/Postgre/Forge.php | 2 ++ system/Database/Postgre/PreparedQuery.php | 2 ++ system/Database/Postgre/Result.php | 2 ++ system/Database/Postgre/Utils.php | 2 ++ system/Database/PreparedQueryInterface.php | 2 ++ system/Database/Query.php | 2 ++ system/Database/QueryInterface.php | 2 ++ system/Database/RawSql.php | 2 ++ system/Database/ResultInterface.php | 2 ++ system/Database/SQLSRV/Builder.php | 2 ++ system/Database/SQLSRV/Connection.php | 2 ++ system/Database/SQLSRV/Forge.php | 2 ++ system/Database/SQLSRV/PreparedQuery.php | 2 ++ system/Database/SQLSRV/Result.php | 2 ++ system/Database/SQLSRV/Utils.php | 2 ++ system/Database/SQLite3/Builder.php | 2 ++ system/Database/SQLite3/Connection.php | 2 ++ system/Database/SQLite3/Forge.php | 2 ++ system/Database/SQLite3/PreparedQuery.php | 2 ++ system/Database/SQLite3/Result.php | 2 ++ system/Database/SQLite3/Table.php | 2 ++ system/Database/SQLite3/Utils.php | 2 ++ system/Database/Seeder.php | 2 ++ system/Debug/BaseExceptionHandler.php | 2 ++ system/Debug/ExceptionHandler.php | 2 ++ system/Debug/ExceptionHandlerInterface.php | 2 ++ system/Debug/Exceptions.php | 2 ++ system/Debug/Iterator.php | 2 ++ system/Debug/Timer.php | 2 ++ system/Debug/Toolbar.php | 2 ++ system/Debug/Toolbar/Collectors/BaseCollector.php | 2 ++ system/Debug/Toolbar/Collectors/Config.php | 2 ++ system/Debug/Toolbar/Collectors/Database.php | 2 ++ system/Debug/Toolbar/Collectors/Events.php | 2 ++ system/Debug/Toolbar/Collectors/Files.php | 2 ++ system/Debug/Toolbar/Collectors/History.php | 2 ++ system/Debug/Toolbar/Collectors/Logs.php | 2 ++ system/Debug/Toolbar/Collectors/Routes.php | 2 ++ system/Debug/Toolbar/Collectors/Timers.php | 2 ++ system/Debug/Toolbar/Collectors/Views.php | 2 ++ system/Debug/Toolbar/Views/toolbar.tpl.php | 2 +- system/Email/Email.php | 2 ++ system/Encryption/EncrypterInterface.php | 2 ++ system/Encryption/Encryption.php | 2 ++ system/Encryption/Exceptions/EncryptionException.php | 2 ++ system/Encryption/Handlers/BaseHandler.php | 2 ++ system/Encryption/Handlers/OpenSSLHandler.php | 2 ++ system/Encryption/Handlers/SodiumHandler.php | 2 ++ system/Entity.php | 2 ++ system/Entity/Cast/ArrayCast.php | 2 ++ system/Entity/Cast/BaseCast.php | 2 ++ system/Entity/Cast/BooleanCast.php | 2 ++ system/Entity/Cast/CSVCast.php | 2 ++ system/Entity/Cast/CastInterface.php | 2 ++ system/Entity/Cast/DatetimeCast.php | 2 ++ system/Entity/Cast/FloatCast.php | 2 ++ system/Entity/Cast/IntBoolCast.php | 2 ++ system/Entity/Cast/IntegerCast.php | 2 ++ system/Entity/Cast/JsonCast.php | 2 ++ system/Entity/Cast/ObjectCast.php | 2 ++ system/Entity/Cast/StringCast.php | 2 ++ system/Entity/Cast/TimestampCast.php | 2 ++ system/Entity/Cast/URICast.php | 2 ++ system/Entity/Entity.php | 2 ++ system/Entity/Exceptions/CastException.php | 2 ++ system/Events/Events.php | 2 ++ system/Exceptions/AlertError.php | 2 ++ system/Exceptions/CastException.php | 2 ++ system/Exceptions/ConfigException.php | 2 ++ system/Exceptions/CriticalError.php | 2 ++ system/Exceptions/DebugTraceableTrait.php | 2 ++ system/Exceptions/DownloadException.php | 2 ++ system/Exceptions/EmergencyError.php | 2 ++ system/Exceptions/ExceptionInterface.php | 2 ++ system/Exceptions/FrameworkException.php | 2 ++ system/Exceptions/HTTPExceptionInterface.php | 2 ++ system/Exceptions/HasExitCodeInterface.php | 2 ++ system/Exceptions/ModelException.php | 2 ++ system/Exceptions/PageNotFoundException.php | 2 ++ system/Exceptions/TestException.php | 2 ++ system/Files/Exceptions/FileException.php | 2 ++ system/Files/Exceptions/FileNotFoundException.php | 2 ++ system/Files/File.php | 2 ++ system/Files/FileCollection.php | 2 ++ system/Filters/CSRF.php | 2 ++ system/Filters/DebugToolbar.php | 2 ++ system/Filters/Exceptions/FilterException.php | 2 ++ system/Filters/FilterInterface.php | 2 ++ system/Filters/Filters.php | 2 ++ system/Filters/Honeypot.php | 2 ++ system/Filters/InvalidChars.php | 2 ++ system/Filters/SecureHeaders.php | 2 ++ system/Format/Exceptions/FormatException.php | 2 ++ system/Format/Format.php | 2 ++ system/Format/FormatterInterface.php | 2 ++ system/Format/JSONFormatter.php | 2 ++ system/Format/XMLFormatter.php | 2 ++ system/HTTP/CLIRequest.php | 2 ++ system/HTTP/CURLRequest.php | 2 ++ system/HTTP/ContentSecurityPolicy.php | 2 ++ system/HTTP/DownloadResponse.php | 2 ++ system/HTTP/Exceptions/HTTPException.php | 2 ++ system/HTTP/Exceptions/RedirectException.php | 2 ++ system/HTTP/Files/FileCollection.php | 2 ++ system/HTTP/Files/UploadedFile.php | 2 ++ system/HTTP/Files/UploadedFileInterface.php | 2 ++ system/HTTP/Header.php | 2 ++ system/HTTP/IncomingRequest.php | 2 ++ system/HTTP/Message.php | 2 ++ system/HTTP/MessageInterface.php | 2 ++ system/HTTP/MessageTrait.php | 2 ++ system/HTTP/Negotiate.php | 2 ++ system/HTTP/OutgoingRequest.php | 2 ++ system/HTTP/OutgoingRequestInterface.php | 2 ++ system/HTTP/RedirectResponse.php | 2 ++ system/HTTP/Request.php | 2 ++ system/HTTP/RequestInterface.php | 2 ++ system/HTTP/RequestTrait.php | 2 ++ system/HTTP/ResponsableInterface.php | 2 ++ system/HTTP/Response.php | 2 ++ system/HTTP/ResponseInterface.php | 2 ++ system/HTTP/ResponseTrait.php | 2 ++ system/HTTP/SiteURI.php | 2 ++ system/HTTP/SiteURIFactory.php | 2 ++ system/HTTP/URI.php | 2 ++ system/HTTP/UserAgent.php | 2 ++ system/Helpers/array_helper.php | 2 ++ system/Helpers/cookie_helper.php | 2 ++ system/Helpers/date_helper.php | 2 ++ system/Helpers/filesystem_helper.php | 2 ++ system/Helpers/form_helper.php | 2 ++ system/Helpers/html_helper.php | 2 ++ system/Helpers/inflector_helper.php | 2 ++ system/Helpers/kint_helper.php | 2 ++ system/Helpers/number_helper.php | 2 ++ system/Helpers/security_helper.php | 2 ++ system/Helpers/test_helper.php | 2 ++ system/Helpers/text_helper.php | 2 ++ system/Helpers/url_helper.php | 2 ++ system/Helpers/xml_helper.php | 2 ++ system/Honeypot/Exceptions/HoneypotException.php | 2 ++ system/Honeypot/Honeypot.php | 2 ++ system/HotReloader/DirectoryHasher.php | 2 ++ system/HotReloader/HotReloader.php | 2 ++ system/HotReloader/IteratorFilter.php | 2 ++ system/I18n/Exceptions/I18nException.php | 2 ++ system/I18n/Time.php | 2 ++ system/I18n/TimeDifference.php | 2 ++ system/I18n/TimeLegacy.php | 2 ++ system/I18n/TimeTrait.php | 2 ++ system/Images/Exceptions/ImageException.php | 2 ++ system/Images/Handlers/BaseHandler.php | 2 ++ system/Images/Handlers/GDHandler.php | 2 ++ system/Images/Handlers/ImageMagickHandler.php | 2 ++ system/Images/Image.php | 2 ++ system/Images/ImageHandlerInterface.php | 2 ++ system/Language/Language.php | 2 ++ system/Language/en/CLI.php | 2 ++ system/Language/en/Cache.php | 2 ++ system/Language/en/Cast.php | 2 ++ system/Language/en/Cookie.php | 2 ++ system/Language/en/Core.php | 2 ++ system/Language/en/Database.php | 2 ++ system/Language/en/Email.php | 2 ++ system/Language/en/Encryption.php | 2 ++ system/Language/en/Errors.php | 2 ++ system/Language/en/Fabricator.php | 2 ++ system/Language/en/Files.php | 2 ++ system/Language/en/Filters.php | 2 ++ system/Language/en/Format.php | 2 ++ system/Language/en/HTTP.php | 2 ++ system/Language/en/Images.php | 2 ++ system/Language/en/Language.php | 2 ++ system/Language/en/Log.php | 2 ++ system/Language/en/Migrations.php | 2 ++ system/Language/en/Number.php | 2 ++ system/Language/en/Pager.php | 2 ++ system/Language/en/Publisher.php | 2 ++ system/Language/en/RESTful.php | 2 ++ system/Language/en/Router.php | 2 ++ system/Language/en/Security.php | 2 ++ system/Language/en/Session.php | 2 ++ system/Language/en/Test.php | 2 ++ system/Language/en/Time.php | 2 ++ system/Language/en/Validation.php | 2 ++ system/Language/en/View.php | 2 ++ system/Log/Exceptions/LogException.php | 2 ++ system/Log/Handlers/BaseHandler.php | 2 ++ system/Log/Handlers/ChromeLoggerHandler.php | 2 ++ system/Log/Handlers/ErrorlogHandler.php | 2 ++ system/Log/Handlers/FileHandler.php | 2 ++ system/Log/Handlers/HandlerInterface.php | 2 ++ system/Log/Logger.php | 2 ++ system/Model.php | 2 ++ system/Modules/Modules.php | 2 ++ system/Pager/Exceptions/PagerException.php | 2 ++ system/Pager/Pager.php | 2 ++ system/Pager/PagerInterface.php | 2 ++ system/Pager/PagerRenderer.php | 2 ++ system/Publisher/ContentReplacer.php | 2 ++ system/Publisher/Exceptions/PublisherException.php | 2 ++ system/Publisher/Publisher.php | 2 ++ system/RESTful/BaseResource.php | 2 ++ system/RESTful/ResourceController.php | 2 ++ system/RESTful/ResourcePresenter.php | 2 ++ system/Router/AutoRouter.php | 2 ++ system/Router/AutoRouterImproved.php | 2 ++ system/Router/AutoRouterInterface.php | 2 ++ system/Router/DefinedRouteCollector.php | 2 ++ system/Router/Exceptions/MethodNotFoundException.php | 2 ++ system/Router/Exceptions/RedirectException.php | 2 ++ system/Router/Exceptions/RouterException.php | 2 ++ system/Router/RouteCollection.php | 2 ++ system/Router/RouteCollectionInterface.php | 2 ++ system/Router/Router.php | 2 ++ system/Router/RouterInterface.php | 2 ++ system/Security/Exceptions/SecurityException.php | 2 ++ system/Security/Security.php | 2 ++ system/Security/SecurityInterface.php | 2 ++ system/Session/Exceptions/SessionException.php | 2 ++ system/Session/Handlers/ArrayHandler.php | 2 ++ system/Session/Handlers/BaseHandler.php | 2 ++ system/Session/Handlers/Database/MySQLiHandler.php | 2 ++ system/Session/Handlers/Database/PostgreHandler.php | 2 ++ system/Session/Handlers/DatabaseHandler.php | 2 ++ system/Session/Handlers/FileHandler.php | 2 ++ system/Session/Handlers/MemcachedHandler.php | 2 ++ system/Session/Handlers/RedisHandler.php | 2 ++ system/Session/Session.php | 2 ++ system/Session/SessionInterface.php | 2 ++ system/Superglobals.php | 2 ++ system/Test/CIUnitTestCase.php | 2 ++ system/Test/ConfigFromArrayTrait.php | 2 ++ system/Test/Constraints/SeeInDatabase.php | 2 ++ system/Test/ControllerTestTrait.php | 2 ++ system/Test/DOMParser.php | 2 ++ system/Test/DatabaseTestTrait.php | 2 ++ system/Test/Fabricator.php | 2 ++ system/Test/FeatureTestTrait.php | 2 ++ system/Test/FilterTestTrait.php | 2 ++ system/Test/Filters/CITestStreamFilter.php | 2 ++ system/Test/Interfaces/FabricatorModel.php | 2 ++ system/Test/Mock/MockAppConfig.php | 2 ++ system/Test/Mock/MockAutoload.php | 2 ++ system/Test/Mock/MockBuilder.php | 2 ++ system/Test/Mock/MockCLIConfig.php | 2 ++ system/Test/Mock/MockCURLRequest.php | 2 ++ system/Test/Mock/MockCache.php | 2 ++ system/Test/Mock/MockCodeIgniter.php | 2 ++ system/Test/Mock/MockCommon.php | 2 ++ system/Test/Mock/MockConnection.php | 2 ++ system/Test/Mock/MockEmail.php | 2 ++ system/Test/Mock/MockEvents.php | 2 ++ system/Test/Mock/MockFileLogger.php | 2 ++ system/Test/Mock/MockIncomingRequest.php | 2 ++ system/Test/Mock/MockLanguage.php | 2 ++ system/Test/Mock/MockLogger.php | 2 ++ system/Test/Mock/MockQuery.php | 2 ++ system/Test/Mock/MockResourceController.php | 2 ++ system/Test/Mock/MockResourcePresenter.php | 2 ++ system/Test/Mock/MockResponse.php | 2 ++ system/Test/Mock/MockResult.php | 2 ++ system/Test/Mock/MockSecurity.php | 2 ++ system/Test/Mock/MockSecurityConfig.php | 2 ++ system/Test/Mock/MockServices.php | 2 ++ system/Test/Mock/MockSession.php | 2 ++ system/Test/Mock/MockTable.php | 2 ++ system/Test/PhpStreamWrapper.php | 2 ++ system/Test/ReflectionHelper.php | 2 ++ system/Test/StreamFilterTrait.php | 2 ++ system/Test/TestLogger.php | 2 ++ system/Test/TestResponse.php | 2 ++ system/Test/bootstrap.php | 2 ++ system/Throttle/Throttler.php | 2 ++ system/Throttle/ThrottlerInterface.php | 2 ++ system/Traits/ConditionalTrait.php | 2 ++ system/Traits/PropertiesTrait.php | 2 ++ system/Typography/Typography.php | 2 ++ system/Validation/CreditCardRules.php | 2 ++ system/Validation/DotArrayFilter.php | 2 ++ system/Validation/Exceptions/ValidationException.php | 2 ++ system/Validation/FileRules.php | 2 ++ system/Validation/FormatRules.php | 2 ++ system/Validation/Rules.php | 2 ++ system/Validation/Validation.php | 2 ++ system/Validation/ValidationInterface.php | 2 ++ system/View/Cell.php | 2 ++ system/View/Cells/Cell.php | 2 ++ system/View/Exceptions/ViewException.php | 2 ++ system/View/Filters.php | 2 ++ system/View/Parser.php | 2 ++ system/View/Plugins.php | 2 ++ system/View/RendererInterface.php | 2 ++ system/View/Table.php | 2 ++ system/View/View.php | 2 ++ system/View/ViewDecoratorInterface.php | 2 ++ system/View/ViewDecoratorTrait.php | 2 ++ system/bootstrap.php | 2 ++ tests/_support/View/OtherCells/SampleClass.php | 2 ++ 414 files changed, 827 insertions(+), 1 deletion(-) diff --git a/system/API/ResponseTrait.php b/system/API/ResponseTrait.php index 5a350007f3fa..b92a1b808a93 100644 --- a/system/API/ResponseTrait.php +++ b/system/API/ResponseTrait.php @@ -1,5 +1,7 @@ Date: Mon, 29 Aug 2022 18:02:14 +0900 Subject: [PATCH 02/11] refactor: add `declare(strict_types=1)` to tests files --- tests/_support/Autoloader/FatalLocator.php | 2 ++ tests/_support/Autoloader/UnnamespacedClass.php | 2 ++ tests/_support/Autoloader/functions.php | 2 ++ tests/_support/Cache/RestrictiveHandler.php | 2 ++ tests/_support/Cells/StarterCell.php | 2 ++ tests/_support/Commands/AbstractInfo.php | 2 ++ tests/_support/Commands/AppInfo.php | 2 ++ tests/_support/Commands/InvalidCommand.php | 2 ++ tests/_support/Commands/LanguageCommand.php | 2 ++ tests/_support/Commands/ParamsReveal.php | 2 ++ tests/_support/Commands/Unsuffixable.php | 2 ++ tests/_support/Config/BadRegistrar.php | 2 ++ tests/_support/Config/Filters.php | 2 ++ tests/_support/Config/Registrar.php | 2 ++ tests/_support/Config/Routes.php | 2 ++ tests/_support/Config/Services.php | 2 ++ tests/_support/Config/TestRegistrar.php | 2 ++ tests/_support/Config/Validation.php | 2 ++ tests/_support/Controllers/Hello.php | 2 ++ tests/_support/Controllers/Newautorouting.php | 2 ++ tests/_support/Controllers/Popcorn.php | 2 ++ tests/_support/Controllers/Remap.php | 2 ++ .../Database/Migrations/20160428212500_Create_test_tables.php | 2 ++ tests/_support/Database/Seeds/AnotherSeeder.php | 2 ++ tests/_support/Database/Seeds/CITestSeeder.php | 2 ++ tests/_support/Entity/Cast/CastBase64.php | 2 ++ tests/_support/Entity/Cast/CastPassParameters.php | 2 ++ tests/_support/Entity/Cast/NotExtendsBaseCast.php | 2 ++ tests/_support/Entity/User.php | 2 ++ tests/_support/Files/able/apple.php | 2 ++ tests/_support/Files/able/fig_3.php | 2 ++ tests/_support/Files/able/prune_ripe.php | 2 ++ tests/_support/Files/baker/banana.php | 2 ++ tests/_support/Filters/Customfilter.php | 2 ++ tests/_support/Filters/RedirectFilter.php | 2 ++ tests/_support/Helpers/baguette_helper.php | 2 ++ tests/_support/Language/SecondMockLanguage.php | 2 ++ tests/_support/Language/ab-CD/Allin.php | 2 ++ tests/_support/Language/ab/Allin.php | 2 ++ tests/_support/Language/en-ZZ/More.php | 2 ++ tests/_support/Language/en/Allin.php | 2 ++ tests/_support/Language/en/Core.php | 2 ++ tests/_support/Language/en/Foo.php | 2 ++ tests/_support/Language/en/Language.php | 2 ++ tests/_support/Language/en/More.php | 2 ++ tests/_support/Language/en/Nested.php | 2 ++ tests/_support/Language/ru/Language.php | 2 ++ tests/_support/Log/Handlers/TestHandler.php | 2 ++ .../Database/Migrations/2018-01-24-102301_Some_migration.php | 2 ++ .../Migrations/2018-01-24-102302_Another_migration.php | 2 ++ tests/_support/Models/EntityModel.php | 2 ++ tests/_support/Models/EventModel.php | 2 ++ tests/_support/Models/FabricatorModel.php | 2 ++ tests/_support/Models/GetCompiledModelTest.php | 2 ++ tests/_support/Models/JobModel.php | 2 ++ tests/_support/Models/SecondaryModel.php | 2 ++ tests/_support/Models/SimpleEntity.php | 2 ++ tests/_support/Models/StringifyPkeyModel.php | 2 ++ tests/_support/Models/UserModel.php | 2 ++ tests/_support/Models/UserObjModel.php | 2 ++ tests/_support/Models/ValidErrorsModel.php | 2 ++ tests/_support/Models/ValidModel.php | 2 ++ tests/_support/Models/ValidModelRuleGroup.php | 2 ++ tests/_support/Models/WithoutAutoIncrementModel.php | 2 ++ tests/_support/Publishers/TestPublisher.php | 2 ++ tests/_support/RESTful/Worker.php | 2 ++ tests/_support/RESTful/Worker2.php | 2 ++ .../Translation/TranslationNested/TranslationFour.php | 2 ++ tests/_support/Services/Translation/TranslationOne.php | 2 ++ tests/_support/Services/Translation/TranslationThree.php | 2 ++ tests/_support/Services/Translation/TranslationTwo.php | 2 ++ tests/_support/SomeEntity.php | 2 ++ tests/_support/Validation/TestRules.php | 2 ++ tests/_support/View/BadDecorator.php | 2 ++ tests/_support/View/Cells/AdditionCell.php | 2 ++ tests/_support/View/Cells/AwesomeCell.php | 2 ++ tests/_support/View/Cells/BadCell.php | 2 ++ tests/_support/View/Cells/ColorsCell.php | 2 ++ tests/_support/View/Cells/GreetingCell.php | 2 ++ tests/_support/View/Cells/ListerCell.php | 2 ++ tests/_support/View/Cells/MultiplierCell.php | 2 ++ tests/_support/View/Cells/RenderedExtraDataNotice.php | 2 ++ tests/_support/View/Cells/RenderedNotice.php | 2 ++ tests/_support/View/Cells/SimpleNotice.php | 2 ++ tests/_support/View/Cells/lister.php | 4 +++- tests/_support/View/SampleClass.php | 2 ++ tests/_support/View/SampleClassWithInitController.php | 2 ++ tests/_support/View/WorldDecorator.php | 2 ++ tests/_support/Widgets/NopeWidget.php | 2 ++ tests/_support/Widgets/OtherWidget.php | 2 ++ tests/_support/Widgets/SomeWidget.php | 2 ++ tests/system/API/ResponseTraitTest.php | 2 ++ tests/system/AutoReview/FrameworkCodeTest.php | 2 ++ tests/system/Autoloader/AutoloaderTest.php | 2 ++ tests/system/Autoloader/FileLocatorCachedTest.php | 2 ++ tests/system/Autoloader/FileLocatorTest.php | 2 ++ tests/system/CLI/CLITest.php | 2 ++ tests/system/CLI/ConsoleTest.php | 2 ++ tests/system/Cache/CacheFactoryTest.php | 2 ++ tests/system/Cache/CacheMockTest.php | 2 ++ tests/system/Cache/FactoriesCacheFileHandlerTest.php | 2 ++ tests/system/Cache/FactoriesCacheFileVarExportHandlerTest.php | 2 ++ tests/system/Cache/Handlers/AbstractHandlerTest.php | 2 ++ tests/system/Cache/Handlers/BaseHandlerTest.php | 2 ++ tests/system/Cache/Handlers/DummyHandlerTest.php | 2 ++ tests/system/Cache/Handlers/FileHandlerTest.php | 2 ++ tests/system/Cache/Handlers/MemcachedHandlerTest.php | 2 ++ tests/system/Cache/Handlers/PredisHandlerTest.php | 2 ++ tests/system/Cache/Handlers/RedisHandlerTest.php | 2 ++ tests/system/Cache/ResponseCacheTest.php | 2 ++ tests/system/CodeIgniterTest.php | 2 ++ tests/system/Commands/BaseCommandTest.php | 2 ++ tests/system/Commands/CellGeneratorTest.php | 2 ++ tests/system/Commands/ClearCacheTest.php | 2 ++ tests/system/Commands/ClearDebugbarTest.php | 2 ++ tests/system/Commands/ClearLogsTest.php | 2 ++ tests/system/Commands/CommandGeneratorTest.php | 2 ++ tests/system/Commands/CommandTest.php | 2 ++ tests/system/Commands/ConfigGeneratorTest.php | 2 ++ tests/system/Commands/ConfigurableSortImportsTest.php | 2 ++ tests/system/Commands/ControllerGeneratorTest.php | 2 ++ tests/system/Commands/CreateDatabaseTest.php | 2 ++ tests/system/Commands/Database/MigrateStatusTest.php | 2 ++ tests/system/Commands/Database/ShowTableInfoMockIOTest.php | 2 ++ tests/system/Commands/Database/ShowTableInfoTest.php | 2 ++ tests/system/Commands/DatabaseCommandsTest.php | 2 ++ tests/system/Commands/EntityGeneratorTest.php | 2 ++ tests/system/Commands/EnvironmentCommandTest.php | 2 ++ tests/system/Commands/FilterCheckTest.php | 2 ++ tests/system/Commands/FilterGeneratorTest.php | 2 ++ tests/system/Commands/GenerateKeyTest.php | 2 ++ tests/system/Commands/GeneratorsTest.php | 2 ++ tests/system/Commands/HelpCommandTest.php | 2 ++ tests/system/Commands/InfoCacheTest.php | 2 ++ tests/system/Commands/MigrationGeneratorTest.php | 2 ++ tests/system/Commands/MigrationIntegrationTest.php | 2 ++ tests/system/Commands/ModelGeneratorTest.php | 2 ++ tests/system/Commands/PublishCommandTest.php | 2 ++ tests/system/Commands/RoutesTest.php | 2 ++ tests/system/Commands/ScaffoldGeneratorTest.php | 2 ++ tests/system/Commands/SeederGeneratorTest.php | 2 ++ tests/system/Commands/Translation/LocalizationFinderTest.php | 2 ++ tests/system/Commands/Utilities/NamespacesTest.php | 2 ++ .../Commands/Utilities/Routes/AutoRouteCollectorTest.php | 2 ++ .../Routes/AutoRouterImproved/AutoRouteCollectorTest.php | 2 ++ .../Routes/AutoRouterImproved/ControllerMethodReaderTest.php | 2 ++ .../Utilities/Routes/AutoRouterImproved/Controllers/Home.php | 2 ++ .../system/Commands/Utilities/Routes/ControllerFinderTest.php | 2 ++ .../Commands/Utilities/Routes/ControllerMethodReaderTest.php | 2 ++ .../system/Commands/Utilities/Routes/FilterCollectorTest.php | 2 ++ tests/system/Commands/Utilities/Routes/FilterFinderTest.php | 2 ++ .../Commands/Utilities/Routes/SampleURIGeneratorTest.php | 2 ++ tests/system/Commands/ValidationGeneratorTest.php | 2 ++ tests/system/CommonFunctionsSendTest.php | 2 ++ tests/system/CommonFunctionsTest.php | 2 ++ tests/system/CommonHelperTest.php | 2 ++ tests/system/CommonSingleServiceTest.php | 2 ++ tests/system/Config/BaseConfigTest.php | 2 ++ tests/system/Config/DotEnvTest.php | 2 ++ tests/system/Config/FactoriesTest.php | 2 ++ tests/system/Config/MimesTest.php | 2 ++ tests/system/Config/ServicesTest.php | 2 ++ tests/system/Config/fixtures/Encryption.php | 2 ++ tests/system/Config/fixtures/RegistrarConfig.php | 2 ++ tests/system/Config/fixtures/SimpleConfig.php | 2 ++ tests/system/ControllerTest.php | 2 ++ tests/system/Cookie/CookieStoreTest.php | 2 ++ tests/system/Cookie/CookieTest.php | 2 ++ tests/system/Database/BaseConnectionTest.php | 2 ++ tests/system/Database/BaseQueryTest.php | 2 ++ tests/system/Database/Builder/AliasTest.php | 2 ++ tests/system/Database/Builder/BaseTest.php | 2 ++ tests/system/Database/Builder/CountTest.php | 2 ++ tests/system/Database/Builder/DeleteTest.php | 2 ++ tests/system/Database/Builder/DistinctTest.php | 2 ++ tests/system/Database/Builder/EmptyTest.php | 2 ++ tests/system/Database/Builder/FromTest.php | 2 ++ tests/system/Database/Builder/GetTest.php | 2 ++ tests/system/Database/Builder/GroupTest.php | 2 ++ tests/system/Database/Builder/InsertTest.php | 2 ++ tests/system/Database/Builder/JoinTest.php | 2 ++ tests/system/Database/Builder/LikeTest.php | 2 ++ tests/system/Database/Builder/LimitTest.php | 2 ++ tests/system/Database/Builder/OrderTest.php | 2 ++ tests/system/Database/Builder/PrefixTest.php | 2 ++ tests/system/Database/Builder/ReplaceTest.php | 2 ++ tests/system/Database/Builder/SelectTest.php | 2 ++ tests/system/Database/Builder/TruncateTest.php | 2 ++ tests/system/Database/Builder/UnionTest.php | 2 ++ tests/system/Database/Builder/UpdateTest.php | 2 ++ tests/system/Database/Builder/WhenTest.php | 2 ++ tests/system/Database/Builder/WhereTest.php | 2 ++ tests/system/Database/ConfigTest.php | 2 ++ tests/system/Database/DatabaseSeederTest.php | 2 ++ .../DatabaseTestCase/DatabaseTestCaseMigrationOnce1Test.php | 2 ++ .../DatabaseTestCase/DatabaseTestCaseMigrationOnce2Test.php | 2 ++ tests/system/Database/DatabaseTestCaseTest.php | 2 ++ tests/system/Database/Forge/CreateTableTest.php | 2 ++ tests/system/Database/Forge/DropForeignKeyTest.php | 2 ++ tests/system/Database/Live/AliasTest.php | 2 ++ tests/system/Database/Live/BadQueryTest.php | 2 ++ tests/system/Database/Live/ConnectTest.php | 2 ++ tests/system/Database/Live/CountTest.php | 2 ++ tests/system/Database/Live/DatabaseTestTraitCaseTest.php | 2 ++ tests/system/Database/Live/DbDebugTest.php | 2 ++ tests/system/Database/Live/DbUtilsTest.php | 2 ++ tests/system/Database/Live/DeleteTest.php | 2 ++ tests/system/Database/Live/EmptyTest.php | 2 ++ tests/system/Database/Live/EscapeTest.php | 2 ++ tests/system/Database/Live/FabricatorLiveTest.php | 2 ++ tests/system/Database/Live/ForgeTest.php | 2 ++ tests/system/Database/Live/FromTest.php | 2 ++ tests/system/Database/Live/GetNumRowsTest.php | 2 ++ tests/system/Database/Live/GetTest.php | 2 ++ tests/system/Database/Live/GetVersionTest.php | 2 ++ tests/system/Database/Live/GroupTest.php | 2 ++ tests/system/Database/Live/IncrementTest.php | 2 ++ tests/system/Database/Live/InsertTest.php | 2 ++ tests/system/Database/Live/JoinTest.php | 2 ++ tests/system/Database/Live/LikeTest.php | 2 ++ tests/system/Database/Live/LimitTest.php | 2 ++ tests/system/Database/Live/MetadataTest.php | 2 ++ tests/system/Database/Live/MySQLi/NumberNativeTest.php | 2 ++ tests/system/Database/Live/MySQLi/RawSqlTest.php | 2 ++ tests/system/Database/Live/OCI8/CallStoredProcedureTest.php | 2 ++ tests/system/Database/Live/OCI8/LastInsertIDTest.php | 2 ++ tests/system/Database/Live/OrderTest.php | 2 ++ tests/system/Database/Live/PreparedQueryTest.php | 2 ++ tests/system/Database/Live/PretendTest.php | 2 ++ tests/system/Database/Live/SQLite/AlterTableTest.php | 2 ++ tests/system/Database/Live/SQLite/GetIndexDataTest.php | 2 ++ tests/system/Database/Live/SelectTest.php | 2 ++ tests/system/Database/Live/TransactionDBDebugFalseTest.php | 2 ++ tests/system/Database/Live/TransactionDBDebugTrueTest.php | 2 ++ tests/system/Database/Live/TransactionTest.php | 2 ++ tests/system/Database/Live/UnionTest.php | 2 ++ tests/system/Database/Live/UpdateTest.php | 2 ++ tests/system/Database/Live/UpsertTest.php | 2 ++ tests/system/Database/Live/WhereTest.php | 2 ++ tests/system/Database/Live/WriteTypeQueryTest.php | 2 ++ tests/system/Database/Migrations/MigrationRunnerTest.php | 2 ++ tests/system/Database/Migrations/MigrationTest.php | 2 ++ tests/system/Database/RawSqlTest.php | 2 ++ tests/system/Debug/ExceptionHandlerTest.php | 2 ++ tests/system/Debug/ExceptionsTest.php | 2 ++ tests/system/Debug/TimerTest.php | 2 ++ tests/system/Debug/Toolbar/Collectors/DatabaseTest.php | 2 ++ tests/system/Debug/Toolbar/Collectors/HistoryTest.php | 2 ++ tests/system/DebugTraceableTraitTest.php | 2 ++ tests/system/Email/EmailTest.php | 2 ++ tests/system/Encryption/EncryptionTest.php | 2 ++ tests/system/Encryption/Handlers/OpenSSLHandlerTest.php | 2 ++ tests/system/Encryption/Handlers/SodiumHandlerTest.php | 2 ++ tests/system/Entity/EntityTest.php | 2 ++ tests/system/Events/EventsTest.php | 2 ++ tests/system/Files/FileCollectionTest.php | 2 ++ tests/system/Files/FileTest.php | 2 ++ tests/system/Files/FileWithVfsTest.php | 2 ++ tests/system/Filters/CSRFTest.php | 2 ++ tests/system/Filters/DebugToolbarTest.php | 2 ++ tests/system/Filters/FiltersTest.php | 2 ++ tests/system/Filters/HoneypotTest.php | 2 ++ tests/system/Filters/InvalidCharsTest.php | 2 ++ tests/system/Filters/SecureHeadersTest.php | 2 ++ tests/system/Filters/fixtures/GoogleCurious.php | 2 ++ tests/system/Filters/fixtures/GoogleEmpty.php | 2 ++ tests/system/Filters/fixtures/GoogleMe.php | 2 ++ tests/system/Filters/fixtures/GoogleYou.php | 2 ++ tests/system/Filters/fixtures/InvalidClass.php | 2 ++ tests/system/Filters/fixtures/Multiple1.php | 2 ++ tests/system/Filters/fixtures/Multiple2.php | 2 ++ tests/system/Filters/fixtures/Role.php | 2 ++ tests/system/Format/FormatTest.php | 2 ++ tests/system/Format/JSONFormatterTest.php | 2 ++ tests/system/Format/XMLFormatterTest.php | 2 ++ tests/system/HTTP/CLIRequestTest.php | 2 ++ tests/system/HTTP/CURLRequestDoNotShareOptionsTest.php | 2 ++ tests/system/HTTP/CURLRequestTest.php | 2 ++ tests/system/HTTP/ContentSecurityPolicyTest.php | 2 ++ tests/system/HTTP/DownloadResponseTest.php | 2 ++ tests/system/HTTP/Files/FileCollectionTest.php | 2 ++ tests/system/HTTP/Files/FileMovingTest.php | 2 ++ tests/system/HTTP/HeaderTest.php | 2 ++ tests/system/HTTP/IncomingRequestDetectingTest.php | 2 ++ tests/system/HTTP/IncomingRequestTest.php | 2 ++ tests/system/HTTP/MessageTest.php | 2 ++ tests/system/HTTP/NegotiateTest.php | 2 ++ tests/system/HTTP/OutgoingRequestTest.php | 2 ++ tests/system/HTTP/RedirectExceptionTest.php | 2 ++ tests/system/HTTP/RedirectResponseTest.php | 2 ++ tests/system/HTTP/RequestTest.php | 2 ++ tests/system/HTTP/ResponseCookieTest.php | 2 ++ tests/system/HTTP/ResponseSendTest.php | 2 ++ tests/system/HTTP/ResponseTest.php | 2 ++ tests/system/HTTP/SiteURIFactoryDetectRoutePathTest.php | 2 ++ tests/system/HTTP/SiteURIFactoryTest.php | 2 ++ tests/system/HTTP/SiteURITest.php | 2 ++ tests/system/HTTP/URITest.php | 2 ++ tests/system/HTTP/UserAgentTest.php | 2 ++ tests/system/Helpers/Array/ArrayHelperDotKeyExistsTest.php | 2 ++ tests/system/Helpers/Array/ArrayHelperRecursiveDiffTest.php | 2 ++ tests/system/Helpers/ArrayHelperTest.php | 2 ++ tests/system/Helpers/CookieHelperTest.php | 2 ++ tests/system/Helpers/DateHelperTest.php | 2 ++ tests/system/Helpers/FilesystemHelperTest.php | 2 ++ tests/system/Helpers/FormHelperTest.php | 2 ++ tests/system/Helpers/HTMLHelperTest.php | 2 ++ tests/system/Helpers/InflectorHelperTest.php | 2 ++ tests/system/Helpers/NumberHelperTest.php | 2 ++ tests/system/Helpers/SecurityHelperTest.php | 2 ++ tests/system/Helpers/TextHelperTest.php | 2 ++ tests/system/Helpers/URLHelper/CurrentUrlTest.php | 2 ++ tests/system/Helpers/URLHelper/MiscUrlTest.php | 2 ++ tests/system/Helpers/URLHelper/SiteUrlCliTest.php | 2 ++ tests/system/Helpers/URLHelper/SiteUrlTest.php | 2 ++ tests/system/Helpers/XMLHelperTest.php | 2 ++ tests/system/HomeTest.php | 2 ++ tests/system/Honeypot/HoneypotTest.php | 2 ++ tests/system/HotReloader/DirectoryHasherTest.php | 2 ++ tests/system/I18n/TimeDifferenceTest.php | 2 ++ tests/system/I18n/TimeLegacyTest.php | 2 ++ tests/system/I18n/TimeTest.php | 2 ++ tests/system/Images/BaseHandlerTest.php | 2 ++ tests/system/Images/GDHandlerTest.php | 2 ++ tests/system/Images/ImageMagickHandlerTest.php | 2 ++ tests/system/Images/ImageTest.php | 2 ++ tests/system/Language/LanguageTest.php | 2 ++ tests/system/Log/Handlers/ChromeLoggerHandlerTest.php | 2 ++ tests/system/Log/Handlers/ErrorlogHandlerTest.php | 2 ++ tests/system/Log/Handlers/FileHandlerTest.php | 2 ++ tests/system/Log/LoggerTest.php | 2 ++ tests/system/Models/AffectedRowsTest.php | 2 ++ tests/system/Models/CountAllModelTest.php | 2 ++ tests/system/Models/DeleteModelTest.php | 2 ++ tests/system/Models/EventsModelTest.php | 2 ++ tests/system/Models/FindModelTest.php | 2 ++ tests/system/Models/GeneralModelTest.php | 2 ++ tests/system/Models/InsertModelTest.php | 2 ++ tests/system/Models/LiveModelTestCase.php | 2 ++ tests/system/Models/MiscellaneousModelTest.php | 2 ++ tests/system/Models/PaginateModelTest.php | 2 ++ tests/system/Models/ReplaceModelTest.php | 2 ++ tests/system/Models/SaveModelTest.php | 2 ++ tests/system/Models/UpdateModelTest.php | 2 ++ tests/system/Models/ValidationModelRuleGroupTest.php | 2 ++ tests/system/Models/ValidationModelTest.php | 2 ++ tests/system/Models/WhenWhenNotModelTest.php | 2 ++ tests/system/Pager/PagerRendererTest.php | 2 ++ tests/system/Pager/PagerTest.php | 2 ++ tests/system/Publisher/ContentReplacerTest.php | 2 ++ tests/system/Publisher/PublisherContentReplaceTest.php | 2 ++ tests/system/Publisher/PublisherInputTest.php | 2 ++ tests/system/Publisher/PublisherOutputTest.php | 2 ++ tests/system/Publisher/PublisherRestrictionsTest.php | 2 ++ tests/system/Publisher/PublisherSupportTest.php | 2 ++ tests/system/RESTful/ResourceControllerTest.php | 2 ++ tests/system/RESTful/ResourcePresenterTest.php | 2 ++ tests/system/Router/AutoRouterImprovedTest.php | 2 ++ .../system/Router/Controllers/Dash_folder/Dash_controller.php | 2 ++ tests/system/Router/Controllers/Dash_folder/Home.php | 2 ++ tests/system/Router/Controllers/Dash_folder/Mycontroller.php | 2 ++ tests/system/Router/Controllers/Home.php | 2 ++ tests/system/Router/Controllers/Index.php | 2 ++ tests/system/Router/Controllers/Mycontroller.php | 2 ++ tests/system/Router/Controllers/Remap.php | 2 ++ tests/system/Router/Controllers/Subfolder/Home.php | 2 ++ tests/system/Router/Controllers/Subfolder/Mycontroller.php | 2 ++ .../system/Router/Controllers/Subfolder/Sub/Mycontroller.php | 2 ++ tests/system/Router/DefinedRouteCollectorTest.php | 2 ++ tests/system/Router/RouteCollectionReverseRouteTest.php | 2 ++ tests/system/Router/RouteCollectionTest.php | 2 ++ tests/system/Router/RouterTest.php | 2 ++ .../system/Security/SecurityCSRFCookieRandomizeTokenTest.php | 2 ++ .../system/Security/SecurityCSRFSessionRandomizeTokenTest.php | 2 ++ tests/system/Security/SecurityCSRFSessionTest.php | 2 ++ tests/system/Security/SecurityTest.php | 2 ++ .../Session/Handlers/Database/AbstractHandlerTestCase.php | 2 ++ tests/system/Session/Handlers/Database/MySQLiHandlerTest.php | 2 ++ tests/system/Session/Handlers/Database/PostgreHandlerTest.php | 2 ++ tests/system/Session/Handlers/Database/RedisHandlerTest.php | 2 ++ tests/system/Session/SessionTest.php | 2 ++ tests/system/SparkTest.php | 2 ++ tests/system/SuperglobalsTest.php | 2 ++ tests/system/Test/BootstrapFCPATHTest.php | 2 ++ tests/system/Test/ControllerTestTraitTest.php | 2 ++ tests/system/Test/DOMParserTest.php | 2 ++ tests/system/Test/FabricatorTest.php | 2 ++ tests/system/Test/FeatureTestAutoRoutingImprovedTest.php | 2 ++ tests/system/Test/FeatureTestTraitTest.php | 2 ++ tests/system/Test/FilterTestTraitTest.php | 2 ++ tests/system/Test/ReflectionHelperTest.php | 2 ++ tests/system/Test/TestCaseEmissionsTest.php | 2 ++ tests/system/Test/TestCaseTest.php | 2 ++ tests/system/Test/TestLoggerTest.php | 2 ++ tests/system/Test/TestResponseTest.php | 2 ++ tests/system/Throttle/ThrottleTest.php | 2 ++ tests/system/Typography/TypographyTest.php | 2 ++ tests/system/Validation/CreditCardRulesTest.php | 2 ++ tests/system/Validation/DatabaseRelatedRulesTest.php | 2 ++ tests/system/Validation/DotArrayFilterTest.php | 2 ++ tests/system/Validation/FileRulesTest.php | 2 ++ tests/system/Validation/FormatRulesTest.php | 2 ++ tests/system/Validation/RulesTest.php | 2 ++ tests/system/Validation/StrictRules/CreditCardRulesTest.php | 2 ++ .../Validation/StrictRules/DatabaseRelatedRulesTest.php | 2 ++ tests/system/Validation/StrictRules/FileRulesTest.php | 2 ++ tests/system/Validation/StrictRules/FormatRulesTest.php | 2 ++ tests/system/Validation/StrictRules/RulesTest.php | 2 ++ tests/system/Validation/StrictRules/ValidationTest.php | 2 ++ tests/system/Validation/ValidationTest.php | 2 ++ tests/system/View/CellTest.php | 2 ++ tests/system/View/ControlledCellTest.php | 2 ++ tests/system/View/DecoratorsTest.php | 2 ++ tests/system/View/ParserFilterTest.php | 2 ++ tests/system/View/ParserPluginTest.php | 2 ++ tests/system/View/ParserTest.php | 2 ++ tests/system/View/TableTest.php | 2 ++ tests/system/View/ViewTest.php | 2 ++ tests/system/View/Views/nested_section.php | 3 ++- 419 files changed, 839 insertions(+), 2 deletions(-) diff --git a/tests/_support/Autoloader/FatalLocator.php b/tests/_support/Autoloader/FatalLocator.php index 463455759705..578bd02ad9ae 100644 --- a/tests/_support/Autoloader/FatalLocator.php +++ b/tests/_support/Autoloader/FatalLocator.php @@ -1,5 +1,7 @@ + diff --git a/tests/_support/View/SampleClass.php b/tests/_support/View/SampleClass.php index acc982dce225..bb49f3dbc746 100644 --- a/tests/_support/View/SampleClass.php +++ b/tests/_support/View/SampleClass.php @@ -1,5 +1,7 @@ extend('layout'); ?> +extend('layout'); ?> section('content'); ?>

Second

From 4b923d5dbf4c3f6db56bf037df2a8e70f556b880 Mon Sep 17 00:00:00 2001 From: kenjis Date: Sun, 22 Oct 2023 15:23:05 +0900 Subject: [PATCH 03/11] refactor: add `declare(strict_types=1)` to rector.php --- rector.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rector.php b/rector.php index 1eaacd12328b..bcee460f1a3e 100644 --- a/rector.php +++ b/rector.php @@ -1,5 +1,7 @@ Date: Sun, 22 Oct 2023 17:26:33 +0900 Subject: [PATCH 04/11] fix: remove declare(strict_types=1) --- system/CodeIgniter.php | 4 ++-- system/Config/BaseConfig.php | 5 +++-- system/Test/ControllerTestTrait.php | 4 ++-- system/View/Parser.php | 3 +-- tests/system/Debug/ExceptionsTest.php | 3 +-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php index 368b6130cf49..b7a6f4ae5d16 100644 --- a/system/CodeIgniter.php +++ b/system/CodeIgniter.php @@ -1,7 +1,5 @@ router->params(); + // The controller method param types may not be string. + // So cannot set `declare(strict_types=1)` in this file. $output = method_exists($class, '_remap') ? $class->_remap($this->method, ...$params) : $class->{$this->method}(...$params); diff --git a/system/Config/BaseConfig.php b/system/Config/BaseConfig.php index ed6fa3e2bc68..6789c0e9c76b 100644 --- a/system/Config/BaseConfig.php +++ b/system/Config/BaseConfig.php @@ -1,7 +1,5 @@ controller->{$method}(...$params); } catch (Throwable $e) { $code = $e->getCode(); diff --git a/system/View/Parser.php b/system/View/Parser.php index 1a684a1d1edc..dc34a7450448 100644 --- a/system/View/Parser.php +++ b/system/View/Parser.php @@ -1,7 +1,5 @@ config->filters[$filter]($replace, ...$param); } diff --git a/tests/system/Debug/ExceptionsTest.php b/tests/system/Debug/ExceptionsTest.php index 7285d3e4355b..3f45399c3cb4 100644 --- a/tests/system/Debug/ExceptionsTest.php +++ b/tests/system/Debug/ExceptionsTest.php @@ -1,7 +1,5 @@ = 80100 ? null : 'random string'; try { + // We test DEPRECATED error, so cannot set `declare(strict_types=1)` in this file. strlen($maybeNull); $this->assertLogContains('error', '[DEPRECATED] strlen(): '); } catch (ErrorException $e) { From bb89363dcf424ef00a6eabce202e8a86ddd47cd7 Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 30 Oct 2023 12:57:52 +0900 Subject: [PATCH 05/11] refactor: remove unnecessary check --- system/Honeypot/Honeypot.php | 4 ---- tests/system/Honeypot/HoneypotTest.php | 7 ------- 2 files changed, 11 deletions(-) diff --git a/system/Honeypot/Honeypot.php b/system/Honeypot/Honeypot.php index e0879f157ed2..a53b84686e9a 100644 --- a/system/Honeypot/Honeypot.php +++ b/system/Honeypot/Honeypot.php @@ -42,10 +42,6 @@ public function __construct(HoneypotConfig $config) { $this->config = $config; - if (! $this->config->hidden) { - throw HoneypotException::forNoHiddenValue(); - } - if (empty($this->config->container) || strpos($this->config->container, '{template}') === false) { $this->config->container = '
{template}
'; } diff --git a/tests/system/Honeypot/HoneypotTest.php b/tests/system/Honeypot/HoneypotTest.php index 28b7348a7e11..f98d61294ed8 100644 --- a/tests/system/Honeypot/HoneypotTest.php +++ b/tests/system/Honeypot/HoneypotTest.php @@ -133,13 +133,6 @@ public function testHasContent(): void $this->assertTrue($this->honeypot->hasContent($this->request)); } - public function testConfigHidden(): void - { - $this->config->hidden = ''; - $this->expectException(HoneypotException::class); - $this->honeypot = new Honeypot($this->config); - } - public function testConfigTemplate(): void { $this->config->template = ''; From 77551733ff1f79f11f9cc1db11c45f2c11d421cc Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 30 Oct 2023 12:58:30 +0900 Subject: [PATCH 06/11] test: update test code --- tests/system/Config/DotEnvTest.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/system/Config/DotEnvTest.php b/tests/system/Config/DotEnvTest.php index c20a37399315..6348b1567a59 100644 --- a/tests/system/Config/DotEnvTest.php +++ b/tests/system/Config/DotEnvTest.php @@ -16,6 +16,7 @@ use CodeIgniter\Test\CIUnitTestCase; use org\bovigo\vfs\vfsStream; use org\bovigo\vfs\vfsStreamDirectory; +use TypeError; /** * @backupGlobals enabled @@ -112,12 +113,9 @@ public function testLoadsBase64(): void public function testLoadsNoneStringFiles(): void { - $dotenv = new DotEnv($this->fixturesFolder, 2); - $dotenv->load(); - $this->assertSame('bar', getenv('FOO')); - $this->assertSame('baz', getenv('BAR')); - $this->assertSame('with spaces', getenv('SPACED')); - $this->assertSame('', getenv('NULL')); + $this->expectException(TypeError::class); + + new DotEnv($this->fixturesFolder, 2); } public function testCommentedLoadsVars(): void From 71de6c6fdc394a5e702cbd950806e05e7547f5dc Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 30 Oct 2023 12:58:52 +0900 Subject: [PATCH 07/11] chore: add DeclareStrictTypesRector --- rector.php | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/rector.php b/rector.php index bcee460f1a3e..4410fb2f9464 100644 --- a/rector.php +++ b/rector.php @@ -45,6 +45,7 @@ use Rector\Set\ValueObject\LevelSetList; use Rector\Set\ValueObject\SetList; use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector; +use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector; use Utils\Rector\PassStrictParameterToFunctionParameterRector; use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector; use Utils\Rector\UnderscoreToCamelCaseVariableNameRector; @@ -108,6 +109,19 @@ __DIR__ . '/system/Session/Handlers', ], + DeclareStrictTypesRector::class => [ + __DIR__ . '/app', + __DIR__ . '/system/CodeIgniter.php', + __DIR__ . '/system/Config/BaseConfig.php', + __DIR__ . '/system/Commands/Generators/Views', + __DIR__ . '/system/Pager/Views', + __DIR__ . '/system/Test/ControllerTestTrait.php', + __DIR__ . '/system/Validation/Views', + __DIR__ . '/system/View/Parser.php', + __DIR__ . '/tests/system/Debug/ExceptionsTest.php', + __DIR__ . '/tests/system/View/Views', + ], + // use mt_rand instead of random_int on purpose on non-cryptographically random RandomFunctionRector::class, @@ -118,6 +132,7 @@ $rectorConfig->importNames(); $rectorConfig->removeUnusedImports(); + $rectorConfig->rule(DeclareStrictTypesRector::class); $rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class); $rectorConfig->rule(SimplifyUselessVariableRector::class); $rectorConfig->rule(RemoveAlwaysElseRector::class); From 57c1c33db8172e1932497751cea05a6455abd4e1 Mon Sep 17 00:00:00 2001 From: kenjis Date: Wed, 22 Nov 2023 10:09:20 +0900 Subject: [PATCH 08/11] refactor: add `declare(strict_types=1)` to system files --- system/Commands/Utilities/ConfigCheck.php | 2 ++ system/Config/Filters.php | 2 ++ system/Filters/ForceHTTPS.php | 2 ++ system/Filters/PageCache.php | 2 ++ system/Filters/PerformanceMetrics.php | 2 ++ system/HTTP/Method.php | 2 ++ system/Helpers/Array/ArrayHelper.php | 2 ++ 7 files changed, 14 insertions(+) diff --git a/system/Commands/Utilities/ConfigCheck.php b/system/Commands/Utilities/ConfigCheck.php index 3ab45cc25f1f..c42de1eb7566 100644 --- a/system/Commands/Utilities/ConfigCheck.php +++ b/system/Commands/Utilities/ConfigCheck.php @@ -1,5 +1,7 @@ Date: Wed, 22 Nov 2023 10:09:43 +0900 Subject: [PATCH 09/11] refactor: add `declare(strict_types=1)` to tests files --- tests/system/Commands/Utilities/ConfigCheckTest.php | 2 ++ tests/system/Models/TimestampModelTest.php | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/system/Commands/Utilities/ConfigCheckTest.php b/tests/system/Commands/Utilities/ConfigCheckTest.php index 664a9cf64b7a..e551a1ae94c6 100644 --- a/tests/system/Commands/Utilities/ConfigCheckTest.php +++ b/tests/system/Commands/Utilities/ConfigCheckTest.php @@ -1,5 +1,7 @@ Date: Thu, 30 Nov 2023 16:23:14 +0900 Subject: [PATCH 10/11] docs: update internals.md --- contributing/internals.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/contributing/internals.md b/contributing/internals.md index e2d387028fe1..b49c9832d390 100644 --- a/contributing/internals.md +++ b/contributing/internals.md @@ -29,10 +29,9 @@ PHP7 provides [Type declarations](https://www.php.net/manual/en/language.types.d for method parameters and return types. Use it where possible. Return type declaration is not always practical, but do try to make it work. -At this time, shipped CI4 production code does not use -[Strict typing](https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.strict), -and will not be any time soon. However, in the development phase, -there are internal classes (in `utils/`) that are strictly typed. +At this time, shipped CI4 production code does use +[Strict typing](https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.strict) +as much as possible. ## Abstractions From 5307da0ff18c7945a0906a78c0e3bf946765fd54 Mon Sep 17 00:00:00 2001 From: kenjis Date: Thu, 30 Nov 2023 17:11:29 +0900 Subject: [PATCH 11/11] docs: add changelog --- user_guide_src/source/changelogs/v4.5.0.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/user_guide_src/source/changelogs/v4.5.0.rst b/user_guide_src/source/changelogs/v4.5.0.rst index 2192e4841a5a..bccf8f440625 100644 --- a/user_guide_src/source/changelogs/v4.5.0.rst +++ b/user_guide_src/source/changelogs/v4.5.0.rst @@ -317,6 +317,7 @@ Changes :ref:`multiple-filters` are always enabled. - **RouteCollection:** The HTTP method keys in the protected property ``$routes`` has been fixed from lowercase to uppercase. +- ``declare(strict_types=1)`` has been added to most framework codebase. Deprecations ************