From c18a66188096cb9c450ff46cbca37da48d47cbf1 Mon Sep 17 00:00:00 2001 From: kenjis Date: Wed, 4 Oct 2023 17:24:29 +0900 Subject: [PATCH 1/2] fix: Config\Kint does not extend BaseConfig We do not need to share the Config file, and if we enable Config Caching, it cannot be loaded from FactoriesCache when we run `composer install --no-dev`. Because the autoloader for Kint is initialized in CodeIgniter::initialize(). --- app/Config/Kint.php | 3 +-- system/CodeIgniter.php | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/Config/Kint.php b/app/Config/Kint.php index cc8b54592b6b..36232446889b 100644 --- a/app/Config/Kint.php +++ b/app/Config/Kint.php @@ -2,7 +2,6 @@ namespace Config; -use CodeIgniter\Config\BaseConfig; use Kint\Parser\ConstructablePluginInterface; use Kint\Renderer\AbstractRenderer; use Kint\Renderer\Rich\TabPluginInterface; @@ -18,7 +17,7 @@ * * @see https://kint-php.github.io/kint/ for details on these settings. */ -class Kint extends BaseConfig +class Kint { /* |-------------------------------------------------------------------------- diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php index 22f86b5d4c7e..15ca7f81ad18 100644 --- a/system/CodeIgniter.php +++ b/system/CodeIgniter.php @@ -296,7 +296,7 @@ private function autoloadKint(): void private function configureKint(): void { - $config = config(KintConfig::class); + $config = new KintConfig(); Kint::$depth_limit = $config->maxDepth; Kint::$display_called_from = $config->displayCalledFrom; From ff2c6b65f23b871c6a77e9507ab2f903a8e7a5d8 Mon Sep 17 00:00:00 2001 From: kenjis Date: Wed, 4 Oct 2023 17:53:55 +0900 Subject: [PATCH 2/2] docs: add upgrade_450 --- user_guide_src/source/installation/upgrade_450.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/user_guide_src/source/installation/upgrade_450.rst b/user_guide_src/source/installation/upgrade_450.rst index 7a4fbc0b29da..240203f4b888 100644 --- a/user_guide_src/source/installation/upgrade_450.rst +++ b/user_guide_src/source/installation/upgrade_450.rst @@ -106,6 +106,9 @@ Config - app/Config/Feature.php - ``Config\Feature::$multipleFilters`` has been removed, because now :ref:`multiple-filters` are always enabled. +- app/Config/Kint.php + - It no longer extends ``BaseConfig`` because enabling + :ref:`factories-config-caching` could cause errors. All Changes ===========