diff --git a/phpstan-baseline.php b/phpstan-baseline.php index 8a3e75dfb0ce..50fb6aa285ef 100644 --- a/phpstan-baseline.php +++ b/phpstan-baseline.php @@ -1466,11 +1466,6 @@ 'count' => 1, 'path' => __DIR__ . '/system/Database/OCI8/Connection.php', ]; -$ignoreErrors[] = [ - 'message' => '#^Only booleans are allowed in a negated boolean, array\\|string given\\.$#', - 'count' => 1, - 'path' => __DIR__ . '/system/Database/OCI8/Connection.php', -]; $ignoreErrors[] = [ 'message' => '#^PHPDoc type string of property CodeIgniter\\\\Database\\\\OCI8\\\\Connection\\:\\:\\$escapeChar is not the same as PHPDoc type array\\|string of overridden property CodeIgniter\\\\Database\\\\BaseConnection\\\\:\\:\\$escapeChar\\.$#', 'count' => 1, diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php index dd54bf9d4a11..8cb7e3a4a766 100644 --- a/system/Database/OCI8/Connection.php +++ b/system/Database/OCI8/Connection.php @@ -602,7 +602,7 @@ public function insertID(): int } } - if (! $primaryColumnName) { + if ($primaryColumnName === '') { return 0; }