Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URI::getSegment() returns non-existent segment #7249

Closed
wants to merge 4 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 14, 2023

Description
Fixes #7246 (and #2962)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.4 labels Feb 14, 2023
@michalsn
Copy link
Member

Sorry, by accident I wrote the comment under the issue report: #7246 (comment)

@kenjis kenjis marked this pull request as draft February 15, 2023 23:29
@kenjis
Copy link
Member Author

kenjis commented Feb 15, 2023

Since michalsn is opposed, this PR is put on hold.
#7246 (comment)

@michalsn
Copy link
Member

I was pointing out the potential problem that this change brings.

If everyone wants to treat it as a bug, I'm fine with that. In my opinion, it will be a bit controversial, but we have already made bigger BC changes in the past.

@kenjis
Copy link
Member Author

kenjis commented Feb 16, 2023

I am going to withdraw this BC as it does not seem to be worth much.

@kenjis kenjis closed this Feb 22, 2023
@kenjis kenjis deleted the fix-URI-getSegment branch February 22, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants