Bug: migrate:rollback -b impossible due to TypeError

[christophe-fms]

PHP Version

8.2

CodeIgniter4 Version

4.5.1

CodeIgniter4 Installation Method

Manual (zip or tar.gz)

Which operating systems have you tested for this bug?

Windows

Which server did you use?

apache

Database

MariaDB 10.10.2

What happened?

I got this error when trying to rollback :

Argument #1 ($targetBatch) must be of type int, string given, called in C:\[...]\system\Commands\Database\MigrateRollback.php on line 87 at SYSTEMPATH\Database\MigrationRunner.php:226
Backtrace:
  1    SYSTEMPATH\Commands\Database\MigrateRollback.php:87
       CodeIgniter\Database\MigrationRunner()->regress('52')

Steps to Reproduce

Run this command : php spark migrate:rollback -b 52 (my batch number)

Expected Output

The rollback should have been done with a success message, or an error if function down is not correct

Anything else?

The batch number is considered as a string ('52'), i think the correct call would be CodeIgniter\Database\MigrationRunner()->regress(52)

[neznaika0]

There don't seem to be any tests. This is most likely due to strict_types=1

[kenjis]

Chekc #8958

[christophe-fms]

Thanks, it works fine now :-D

[kenjis]

The PR is not merged yet.
You don't need to close this issue, because it will be closed automatically.