Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: PDO driver not supported #6932

Closed
ampmonteiro opened this issue Dec 2, 2022 · 7 comments · Fixed by #6933
Closed

[Docs]: PDO driver not supported #6932

ampmonteiro opened this issue Dec 2, 2022 · 7 comments · Fixed by #6933
Labels
documentation Pull requests for documentation only

Comments

@ampmonteiro
Copy link

PHP Version

7.3, 7.4, 8.0, 8.1

CodeIgniter4 Version

4

CodeIgniter4 Installation Method

Composer (using codeigniter4/appstarter)

Which operating systems have you tested for this bug?

macOS, Windows, Linux

Which server did you use?

apache

Database

MySQL

What happened?

In sequence of this issue #3922,
In the Docs > Databases > 'Database Configuration)' section as well as in 'Connect to Your Database' in 'Build Your First Application', should be mentioned that PDO driver is not supported.

Steps to Reproduce

Expected Output

Anything else?

No response

@ampmonteiro ampmonteiro added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 2, 2022
@sclubricants sclubricants added enhancement PRs that improve existing functionalities and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Dec 2, 2022
@sclubricants
Copy link
Member

Why would you want to use pdo mysql over mysqli?

I have begun working on a PDO ODBC driver but it has a lot of work to do.

@kenjis
Copy link
Member

kenjis commented Dec 2, 2022

It is documented in Server Requirements:
https://codeigniter4.github.io/CodeIgniter4/intro/requirements.html

@kenjis kenjis added documentation Pull requests for documentation only and removed enhancement PRs that improve existing functionalities labels Dec 3, 2022
@kenjis
Copy link
Member

kenjis commented Dec 3, 2022

I sent a PR #6933

@ampmonteiro
Copy link
Author

ampmonteiro commented Dec 3, 2022

@sclubricants

PDO was created for a reason. It is an Universal driver.

PDO base drives exist since php 5.1, why not use it?

Others frameworks use it, why not CI ?

I think with PDO the code would be more clean and reusable.

@kenjis

English is not my native lang.

So i Think the text should be clear. Something like, " PDO drivers base are not supported."

This should be clear in 3 places:

  • in requirements section
  • in Databases > 'Database Configuration' section
  • in 'Connect to Your Database' in 'Build Your First Application'

Thanks

@kenjis
Copy link
Member

kenjis commented Dec 3, 2022

We will accept your contributions. You could write PDO drivers and send PRs.

CodeIgniter is a community driven project and accepts contributions of code and documentation from the community. These contributions are made in the form of Issues or Pull Requests on the CodeIgniter4 repository on GitHub.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/README.md

I think with PDO the code would be more clean and reusable.

If you say about your application code, no. Your code will hardly change.

@kenjis
Copy link
Member

kenjis commented Dec 3, 2022

I think my PR is sufficient.
It is clearly documented. It is obvious that PDO is not supported now.

*******************
Supported Databases
*******************

A database is required for most web application programming.
Currently supported databases are:

  - MySQL via the *MySQLi* driver (version 5.1 and above only)
  - PostgreSQL via the *Postgre* driver
  - SQLite3 via the *SQLite3* driver
  - MSSQL via the *SQLSRV* driver (version 2005 and above only)
  - Oracle via the *OCI8* driver (version 12.1 and above only)

@kenjis kenjis changed the title [Bug / Docs]: PDO driver not supported [Docs]: PDO driver not supported Dec 3, 2022
@ampmonteiro
Copy link
Author

@kenjis

if you think so, then you can close the issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants