You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would appear to prevent setting values such as 0, "0", an empty string, empty array, etc. You've worked around the boolean false by allowing conversion of the string 'false' in the constructor, but most of the other loose comparisons still apply within the getEnvValue() method itself. Fixing this would likely require three separate if comparisons using $value === false.
The text was updated successfully, but these errors were encountered:
I probably wouldn't have noticed it if it weren't for the update you made to convert 'false' to false, because that just sets off alarms in my head. Unfortunately, since getenv() returns false when it can't find the value, it leads us to the land of choosing between a series of bad options.
For reference, the content of
getEnvValue()
currently looks like this:This would appear to prevent setting values such as 0, "0", an empty string, empty array, etc. You've worked around the boolean false by allowing conversion of the string 'false' in the constructor, but most of the other loose comparisons still apply within the
getEnvValue()
method itself. Fixing this would likely require three separate if comparisons using$value === false
.The text was updated successfully, but these errors were encountered: