Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The Validation::run() method does not match the ValidationInterface. #6224

Closed
iRedds opened this issue Jul 3, 2022 · 6 comments · Fixed by #6253
Closed

Bug: The Validation::run() method does not match the ValidationInterface. #6224

iRedds opened this issue Jul 3, 2022 · 6 comments · Fixed by #6253
Assignees
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@iRedds
Copy link
Collaborator

iRedds commented Jul 3, 2022

CodeIgniter4 Version

4.2.1

What happened?

Missing $dbGroup argument.

public function run(?array $data = null, ?string $group = null, ?string $dbGroup = null): bool

public function run(?array $data = null, ?string $group = null): bool;

@iRedds iRedds added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 3, 2022
@kenjis
Copy link
Member

kenjis commented Jul 3, 2022

It does not seem to be an error.
https://3v4l.org/U59Qp

@kenjis
Copy link
Member

kenjis commented Jul 3, 2022

Do you have any specific problems on this mismatch?

@iRedds
Copy link
Collaborator Author

iRedds commented Jul 3, 2022

No problem. But it seems to me that the meaning in the declaration of the interface is lost if the class that implements it is different.

@kenjis
Copy link
Member

kenjis commented Jul 4, 2022

In this case, it seems that updating the run() method in the ValidationInterface in version 5 would solve the problem.

Or try to change the interface in 4.3?

@iRedds
Copy link
Collaborator Author

iRedds commented Jul 4, 2022

I don't know how to get out of this situation. I thought that the team would find the optimal solution.

@kenjis
Copy link
Member

kenjis commented Sep 7, 2022

Closed by #6253

@kenjis kenjis closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants