-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: Project URI Parser #5930
Comments
Why do we need a new class if the URI class is already designed to parse the url? |
I would agree that I'm not a fan of creating another URI class. I feel that could be confusing. Granted, I'm also a little confused on what you mean by "project specific" URI class. |
I also don't understand what exactly "project specific" URI and "URI meta-segment transformation" are. |
So clearly I haven't explained this well 😅 Maybe "parse" isn't the right word: translate? interpret? So within Router we have the ability to define a URI like
Does that help? |
In CodeIgniter context, URI has two meaning.
This class handles 2, doesn't it? |
Why does this need a new class? Can't we add placeholder support to the existing URI class and use that? I would expect that info to be available on the one that the IncomingRequest class has. |
I don't know if this is the same as Project URI Parser, but I have come to the view that it would be better to have |
Yes, that's precisely the point. Though the intent was to handle more than just the current URL, but also routes, etc |
Yes, |
We have a lot of places where values can be interpolated into a (project) URI. There are also some places that it would be good to add support for such URIs.
I would like to add a new class that handles these centrally, probably a child of URI and maybe merged with the idea of a “project-specific” URI class.
See also: #5923 (comment)
The text was updated successfully, but these errors were encountered: