Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\IncomingRequest method getFiles() - Should really return only arrays? #590

Closed
nowackipawel opened this issue Jul 6, 2017 · 2 comments
Closed

Comments

@nowackipawel
Copy link
Contributor

nowackipawel commented Jul 6, 2017

if yes im wondering if can return empty array if there is no elements inside $_FILES instead of null
screenshot-adm  rpi 2017-07-06 19-01-15

I'd like to propose for line 492:
return is_array($this->files->all())?$this->files->all():[];

@nowackipawel
Copy link
Contributor Author

After some investigation better place to make changes I think is populateFiles method of
class FileCollection.

@lonnieezell
Copy link
Member

To fix another issue earlier today, the returned value is now the FileCollection itself, which has some additional tools to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants