XML formater xmltoarray indexed array incorrect

[bytedevzone]

Don't check numeric key
https://github.com/bcit-ci/CodeIgniter4/blob/develop/system/Format/XMLFormatter.php#L95

Solution

if (! is_numeric($key))
{
$output->addChild("$key", htmlspecialchars("$value"));
} else
{
$output->addChild("item{$key}", htmlspecialchars("$value"));
}

[lonnieezell]

This looks good, but can you provide some sample code that was generating the problem you saw so that I can double-check and verify.

[bytedevzone]

Return data:
return $this->respond([
'productname' => 'Appale',
'tags' => ['Vitamin', 'Fruit']
]);

====================

XML Parsing Error: not well-formed
Location: http://localhost/ympcl1local/ax-app/public/entity/save
Line Number 2, Column 51:Appale<0>Vitamin</0><1>Fruit</1>
--------------------------------------------------^

[samsonasik]

this should already fixed and can be closed.

[lonnieezell]

@samsonasik can you link to the specific code that fixed it? I'll need to ensure we have a test in the system to ensure this works, so want to make sure I get the test right :)

[samsonasik]

Here it is:

code: https://github.com/bcit-ci/CodeIgniter4/blob/e25a4319e155e87323c55c43e0abcc915f4eff7a/system/Format/XMLFormatter.php#L84-L93

test: https://github.com/bcit-ci/CodeIgniter4/blob/e25a4319e155e87323c55c43e0abcc915f4eff7a/tests/system/Format/XMLFormatterTest.php#L43-L56

[lonnieezell]

@samsonasik Perfect. Thanks! Will close.