Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper function uses include instead of include_once #575

Closed
daylightstudio opened this issue Jun 28, 2017 · 1 comment
Closed

helper function uses include instead of include_once #575

daylightstudio opened this issue Jun 28, 2017 · 1 comment

Comments

@daylightstudio
Copy link
Contributor

I'm finding that I may need to include a reference to some helpers in multiple areas of the code which will result in the helper file being included twice. The second time, it essentially is ignored because of the conditional check wrapping the helper functions but the file is still being included. Should this be changed to include_once? This is the line I'm referring to.
https://github.com/bcit-ci/CodeIgniter4/blob/develop/system/Common.php#L541

Thanks for all your efforts.

@lonnieezell
Copy link
Member

That's a good point. Will change. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants