Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Improve unit tests #512

Closed
27 of 35 tasks
jim-parry opened this issue May 20, 2017 · 20 comments
Closed
27 of 35 tasks

WIP Improve unit tests #512

jim-parry opened this issue May 20, 2017 · 20 comments
Assignees
Labels
dev help wanted More help is needed for the proper resolution of an issue or pull request in progress testing Pull requests that changes tests only

Comments

@jim-parry
Copy link
Contributor

jim-parry commented May 20, 2017

Our goal is to achieve 80% code coverage before release.

  • API
  • Autoloader :)
  • CLI :)
  • Cache **
  • Commands **
  • Config :)
  • Database **
  • Migrations
  • Debug **
  • Events :)
  • Exceptions
  • Files :)
  • Filters :)
  • Format :)
  • HTTP :)
  • Helpers :)
  • Honeypot :)
  • i18n --> Time::toFormattedDateString()
  • Images *
  • Language :)
  • Log :)
  • Pager :)
  • Router *
  • Security :)
  • Session **
  • Test :)
  • Throttle :)
  • Typography :)
  • Validation :)
  • View :)
  • CodeIgniter.php *
  • Common.php --> force_https(), is_really_writable(), function_usable(), dd()
  • Controller.php *
  • Entity.php
  • Model.php *
@jim-parry jim-parry added help wanted More help is needed for the proper resolution of an issue or pull request in progress testing Pull requests that changes tests only labels May 20, 2017
@jim-parry jim-parry added this to the Pre-Alpha 2 milestone May 20, 2017
@jim-parry jim-parry assigned jim-parry and unassigned jim-parry May 20, 2017
@jaynarayan89
Copy link
Contributor

Is this list up to date?

@jim-parry
Copy link
Contributor Author

@jaynarayan89 It is indeed up-to-date ... there are lots of unit tests needed :-/

@jim-parry jim-parry self-assigned this May 23, 2018
@jim-parry jim-parry changed the title Improve unit tests WIP Improve unit tests Aug 31, 2018
@paolooo
Copy link

paolooo commented Oct 15, 2018

@jim-parry Is there any discussion on this on how we can help to improve the tests? I'd like to help on Cache.

@jim-parry
Copy link
Contributor Author

Please do! No one has shown much interest in this grunt work, so I have been doing most of it.
I show someone's initials beside a module if they are tackling it, so I wil put yours down for Cache :)

@nikkolai14
Copy link

Hello! Is this still available? I would love to help to improve the Unit Testing. Thanks :)

@jim-parry
Copy link
Contributor Author

@nikkolai14 You bet. Specific needs:

  • database testing for postgres
  • commands, debug, email and sessions
  • model
    If you wanted to tackle one of those groups, that would be great. Let me know which one, and I can put your initials beside it so others know.

@nikkolai14
Copy link

@jim-parry I'll go for the "model" first. thanks :)

@lyagoubisaad
Copy link

hi @jim-parry we are a group of students and we want to contribute ,
are "commands, debug, email and sessions" still available ?

@jim-parry
Copy link
Contributor Author

jim-parry commented Nov 30, 2018

@lyagoubisaad They are. We should chat about these, as they each have some quirks. Send me an email (it is in my profile), letting me know a good time to doa quick zoom conference, so I can learn more.

@jim-parry
Copy link
Contributor Author

jim-parry commented Dec 31, 2018

@paolooo I don't see any activity on your part re unit testing the Cache module, and your fork is 400+ commits behind ours. I will remove you from the unit testing module list, so that others might consider it.

@jim-parry
Copy link
Contributor Author

@nikkolai14 I see no activity on your part re unit testing Model, and your fork is 300+ commits behind ours. I will remove you fro the unit testing module list, so that others might consider picking it up.

@lonnieezell
Copy link
Member

@jim-parry I added Migrations to the list because I realized the MigrationRunner didn't have any coverage, and added my initial next to it. I'm working on tests for that now.

@jim-parry
Copy link
Contributor Author

Thank you:)
They were not down as a separate item because I was treating them as part of "Commands", since they are in Commands/Database :)

@jim-parry jim-parry added the dev label Mar 6, 2019
@atishhamte
Copy link
Contributor

Is this list updated? as I can see the codeigniter and model related test cases already in place

@jim-parry
Copy link
Contributor Author

@atishamte There are unit tests for CodeIgniter & Model, but they only have 71% & 81% coverage at the moment, which is not enough.
I do try to keep the list up-to-date. The double-starred items need tests, and the single-starred items need more tests.
We are almost at 80% code coverage, and I will close the issue when we get there, and raise new individual issues for the testing pieces that should still be done.

@atishhamte
Copy link
Contributor

Sure. I will also try to add test cases which will increase the code coverage.
Hope that's not an issue

@jim-parry
Copy link
Contributor Author

That would be great, thanks!

@jim-parry jim-parry modified the milestones: 4.0.0, 4.0.0-beta.3 Apr 4, 2019
@atishhamte atishhamte mentioned this issue Apr 5, 2019
4 tasks
@atishhamte
Copy link
Contributor

@jim-parry, I have done the test cases for both Database(#1917) andCastAsJson(#1911) which rose the code coverage up to >81%.

@atishhamte
Copy link
Contributor

@jim-parry, could you please update the status list... :)

@jim-parry
Copy link
Contributor Author

We have reached 80% code coverage, yay!
I am closing this issue, and we can continue to chip away at remaining poorly covered areas ... will raise individual issues for each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev help wanted More help is needed for the proper resolution of an issue or pull request in progress testing Pull requests that changes tests only
Projects
None yet
Development

No branches or pull requests

7 participants