Bug: return $this->failValidationError($validation->getErrors()) Has Invalid Signature

[adamfisher]

The documentation for return $this->failValidationError($validation->getErrors()); shows this line is working in the documentation but in reality, I keep getting a 500 error. I am trying to build some validation for my REST API.

But if I pass the following manually then the list of validation errors returns successfully:

return $this->fail($this->validator->getErrors());

CodeIgniter 4 version
4.1.1

Affected module(s)
trait ResponseTrait

Expected behavior, and steps to reproduce if appropriate
Create a POST method in a controller like this and it will fail with 500:

    public function create()
    {
        if($this->validate('vendor')) {
            $vendor = $this->request->getJSON();
            $this->model->insert($vendor);
            return $this->respondCreated();
        }
        return $this->failValidationError($this->validator->getErrors());
    }

but change the last line to this:

return $this->fail($this->validator->getErrors());

and you successfully get back:

{
    "status": 400,
    "error": 400,
    "messages": {
        "first_name": "The first_name field may only contain alphabetical characters.",
        "last_name": "The last_name field may only contain alphabetical characters.",
        "account_type": "The account_type field must be one of: checking,savings.",
        "signature_date": "The signature_date field must contain a valid date."
    }
}

Context
Docker Image: webdevops/php-apache-dev:7.4

[kenjis]

It seems the sample code is not correct.

CodeIgniter4/tests/system/API/ResponseTraitTest.php

Lines 326 to 342 in f19fe36

	public function testValidationError()
	{
	$controller = $this->makeController();
	$controller->failValidationError('Nope', 'FAT CHANCE', 'A Custom Reason');
	$expected = [
	'status' => 400,
	'error' => 'FAT CHANCE',
	'messages' => [
	'error' => 'Nope',
	],
	];
	$this->assertEquals('A Custom Reason', $this->response->getReason());
	$this->assertEquals(400, $this->response->getStatusCode());
	$this->assertEquals($this->formatter->format($expected), $this->response->getBody());
	}