Bug: UploadedFile::store() can't return null

[kenjis]

Describe the bug
UploadedFile::store() could return null:

CodeIgniter4/system/HTTP/Files/UploadedFile.php

Lines 379 to 380 in 7ca2a71

	return ($this->move(WRITEPATH . 'uploads/' . $folderName, $fileName)) ?
	$folderName . $this->name : null;

But the return type is string.

CodeIgniter4/system/HTTP/Files/UploadedFile.php

Line 373 in 7ca2a71

public function store(string $folderName = null, string $fileName = null): string

CodeIgniter 4 version
develop branch.

Affected module(s)
UploadedFile

Expected behavior, and steps to reproduce if appropriate
I'm not sure. If $this->move() fails, what should be returned?

Context

• OS: [macOS 10.15.7]
• Web server [PHP built-in]
• PHP version [7.4.13]

[paulbalandan]

It is strange phpstan didn't flag this incompatible return. 🤔

[kenjis]

I found that $this->move() never returns false. So phpstan does not complains?

CodeIgniter4/system/HTTP/Files/UploadedFile.php

Line 131 in 7ca2a71

public function move(string $targetPath, string $name = null, bool $overwrite = false)

So should it be like this?

--- a/system/HTTP/Files/UploadedFile.php
+++ b/system/HTTP/Files/UploadedFile.php
@@ -376,8 +376,9 @@ class UploadedFile extends File implements UploadedFileInterface
        $fileName   = $fileName ?? $this->getRandomName();
 
        // Move the uploaded file to a new location.
-       return ($this->move(WRITEPATH . 'uploads/' . $folderName, $fileName)) ?
-               $folderName . $this->name : null;
+       $this->move(WRITEPATH . 'uploads/' . $folderName, $fileName);
+
+       return $folderName . $this->name;
    }
 
    //--------------------------------------------------------------------

[kenjis]

I sent PR #4187