Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: BaseBuilder::getCompiledDelete() runs real query #4180

Closed
kenjis opened this issue Jan 29, 2021 · 0 comments · Fixed by #4181
Closed

Bug: BaseBuilder::getCompiledDelete() runs real query #4180

kenjis opened this issue Jan 29, 2021 · 0 comments · Fixed by #4181
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@kenjis
Copy link
Member

kenjis commented Jan 29, 2021

Describe the bug
BaseBuilder::getCompiledDelete() runs real query.

CodeIgniter4/system/Database/BaseBuilder.php

Line 2808 in 7ca2a71

$sql = $this->delete($table, null, $reset);

CodeIgniter 4 version
develop branch.

Affected module(s)
Database

Expected behavior, and steps to reproduce if appropriate
Compiles the deletion query, but does not run the query.

Context

  • OS: [macOS 10.15.7]
  • Web server [PHP built-in]
  • PHP version [7.4.13]
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 29, 2021
@kenjis kenjis mentioned this issue Jan 29, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: BaseBuilder::getCompiledDelete() runs real query kenjis/CodeIgniter4
1 participant
@kenjis