Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Request::withMethod() uses deprecated code #4109

Closed
iRedds opened this issue Jan 16, 2021 · 0 comments · Fixed by #4112
Closed

Bug: Request::withMethod() uses deprecated code #4109

iRedds opened this issue Jan 16, 2021 · 0 comments · Fixed by #4112
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@iRedds
Copy link
Collaborator

iRedds commented Jan 16, 2021

/**
* Returns an instance with the specified method.
*
* @param string $method
*
* @return self
*/
public function withMethod($method)
{
$clone = clone $this;
return $clone->setMethod($method);
}

Describe the bug
The Request::setMethod() method is used, marked as deprecated.
And IMHO the return type must be "static"

CodeIgniter 4 version
develop branch

Affected module(s)
Request

@iRedds iRedds added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 16, 2021
@iRedds iRedds changed the title Bug: Bug: Request::withMethod() uses deprecated code Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant