Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the loader class #39

Closed
vonalbert opened this issue Mar 30, 2016 · 4 comments
Closed

Rename the loader class #39

vonalbert opened this issue Mar 30, 2016 · 4 comments

Comments

@vonalbert
Copy link
Contributor

I see the Loader Class does not actually load a file, but it just locates non-class files. Hence I propose rename it to FileLocator and move it under the CodeIgniter\Autoloader namespace.

If you're ok with it I can take the burden :)

@lonnieezell
Copy link
Member

That sounds good. Originally, I thought there was going to end up being more in there, but it looks like we might not need more than that, so this rename makes sense.

@vonalbert
Copy link
Contributor Author

Ok, I'll make a PR as soon I can. Want me to move it also under the Autoloader namespace or it can stay where it is?

@lonnieezell
Copy link
Member

Moving to autoloader namespace sounds good.

@vonalbert
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants