Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: isRedirect does not respond depending on how redirects are set up. #3654

Closed
lf-uraku-yuki opened this issue Sep 18, 2020 · 0 comments · Fixed by #3658
Closed

Bug: isRedirect does not respond depending on how redirects are set up. #3654

lf-uraku-yuki opened this issue Sep 18, 2020 · 0 comments · Fixed by #3658
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@lf-uraku-yuki
Copy link
Contributor

Describe the bug
HTTP Testing ->isRedirect() returns true for RedirectReseponse returned by
return redirect()->to(url)
but false for Response returned by
return $this->response->redirect(url, method, status_code)
Returns.

If this is the intended specification, there is no problem, but it is a little difficult to understand.

CodeIgniter 4 version
4.0.4

Affected module(s)
CodeIgniter\Test\FeatureResponse

Expected behavior, and steps to reproduce if appropriate
The controller returns a Response that has executed the method redirect.

Context

  • OS: Windows 10 Pro 2004 64bit
  • Web server: php spark serve
  • PHP version: 7.4.10 Thread Safe 64bit
@lf-uraku-yuki lf-uraku-yuki added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant