Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeIgniter4 is ready to work with PHP 7.4? #3389

Closed
circuitmamu opened this issue Jul 23, 2020 · 1 comment
Closed

CodeIgniter4 is ready to work with PHP 7.4? #3389

circuitmamu opened this issue Jul 23, 2020 · 1 comment

Comments

@circuitmamu
Copy link

Please submit feature requests to our forum.
We use github issues to track bugs and planned work.

In PHP 7.4 many new changes comes that reduce the code but some functions affect and change its structure from core

Eg.
implode

$array = array('lastname', 'email', 'phone');
$comma_separated_73 = implode(",", $array); // it uses till PHP 7.3
$comma_separated_73 = implode($array,","); // it uses from PHP 7.4

And in Codeigniter 4 it is many places like database library

So please consider this in feature request

@lonnieezell
Copy link
Member

All of framework tests are currently passing in 7.4 so I believe, yes, it's ready. I've heard of others using it on that version, also.

I think you are misunderstanding a change in implode, though.

Passing the glue after the pieces (i.e. not using the documented order of parameters) has been deprecated.

What you're showing that it uses from 7.4 forward is actually what's being deprecated and won't work, even though it's never been documented to work that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants