Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Documentation Issue #2960

Closed
Melluish opened this issue May 8, 2020 · 2 comments · Fixed by #2961
Closed

Bug: Documentation Issue #2960

Melluish opened this issue May 8, 2020 · 2 comments · Fixed by #2961
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@Melluish
Copy link

Melluish commented May 8, 2020

In "CodeIgniter4/user_guide_src/source/tutorial/news_section.rst" at the very bottom of the "Display the news" section in the note you mention that you're passing the second parameter of "url" to the "esc" function, but in the code snippet you don't appear to be.

Should the parameter be passed or should the note be amended?

@Melluish Melluish added the bug Verified issues on the current code behavior or pull requests that will fix them label May 8, 2020
@jreklund
Copy link
Contributor

jreklund commented May 9, 2020

You should use it, I put the note in the bottom. It's used here:
<p><a href="/news/<?= esc($news_item['slug'], 'url'); ?>">View article</a></p>

I can see #2961 are moving it, closer to where it being used.

@Melluish
Copy link
Author

Melluish commented May 9, 2020

Oh, I see it. Yeah, should be closer to the context in which it's being used. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants