Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Difficult architecture of the codeigniter4 project #2602

Closed
atishhamte opened this issue Feb 24, 2020 · 4 comments
Closed

Bug: Difficult architecture of the codeigniter4 project #2602

atishhamte opened this issue Feb 24, 2020 · 4 comments
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@atishhamte
Copy link
Contributor

CI installed using this command
composer create-project codeigniter4/appstarter -s rc --no-dev

I have gone through the released version of appstarter and found the dependency hierarchy is pretty weird like,

  1. appstarter has a vendor directory
  2. It has codeigniter4/framework directory
  3. Inside this, again the entire CI hierarchy is present like, app, public, writable, system folder which is identical to appstarter directory structure

We can directly have the content inside of "appstarter\vendor\codeigniter4\framework\system" to "appstarter\vendor\codeigniter4".

This will only hold the core framework, not the other inappropriate things like app, public, writable,

@atishhamte atishhamte added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 24, 2020
@niteraven7
Copy link

Can confirm this as well.

@lonnieezell
Copy link
Member

I believe Jim had left those other directories in place so that you could easily reference them to copy any changed files over. They do not conflict with operations.

It's not a bug, and might be behavior that will change at some point, but not immediately. We have had discussions recently about this. Thanks for bringing it up.

@agungsugiarto
Copy link
Contributor

Please open this issue again for remember.

agree with @atishamte, @lonnieezell yes is not conflict with operations, but why not deleted ? Codeigniter4/framework just need core system, folder like app, public, writeable etc is junk.

@atishhamte
Copy link
Contributor Author

I am not able to reopen it. @lonnieezell has to open this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

No branches or pull requests

4 participants