You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Migrations support a variety of naming conventions: "The year, month, and date can be separated from each other by dashes, underscores, or not at all." However, in MigrationRunner the migrations are keyed by their UID (the version portion) and then ksort() orders them. This breaks ordering for mixed version formats:
We already have getObjectUid() which generates a UID for each migration so it should be a simple filter_var, but this will likely cause migrations already run to be detected as "not run" and amount to a breaking change, so should be done with caution.
CodeIgniter 4 version
Latest develop
Affected module(s)
Migrations
The text was updated successfully, but these errors were encountered:
MGatner
added
the
bug
Verified issues on the current code behavior or pull requests that will fix them
label
Nov 4, 2019
Actually the history is run through getObjectUid() as well so probably it would be okay to change it there:
// Remove any migrations already in the history
foreach ($this->getHistory($this->group) as $history)
{
unset($migrations[$this->getObjectUid($history)]);
}
Describe the bug
Migrations support a variety of naming conventions: "The year, month, and date can be separated from each other by dashes, underscores, or not at all." However, in MigrationRunner the migrations are keyed by their UID (the version portion) and then
ksort()
orders them. This breaks ordering for mixed version formats:We already have
getObjectUid()
which generates a UID for each migration so it should be a simple filter_var, but this will likely cause migrations already run to be detected as "not run" and amount to a breaking change, so should be done with caution.CodeIgniter 4 version
Latest develop
Affected module(s)
Migrations
The text was updated successfully, but these errors were encountered: