Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration migrate, rollback and create problems #2147

Closed
muradmustafayev opened this issue Aug 17, 2019 · 6 comments
Closed

Migration migrate, rollback and create problems #2147

muradmustafayev opened this issue Aug 17, 2019 · 6 comments
Labels
waiting for info Issues or pull requests that need further clarification from the author

Comments

@muradmustafayev
Copy link

Nowadays trying Migration after @lonnieezell major refactor (08-11-2019, 10:22 PM).

Find out these problems: FYI @MGatner

  • If will be error (such as Duplicate column name 'id') after call php spark migrate will be created tables and migration table stays empty.
  • Because of the bug above when want to rollback there'll be no changes.
  • Refresh command also not working in this situation. Should drop tables manually and then run migrate again
@MGatner
Copy link
Member

MGatner commented Aug 17, 2019

The old migrations table isn’t compatible and will definitely need to be dropped. The current revision has some implementation issues with the batches so there’s another version coming soon - I don’t recommend dedicating any efforts to the current state. If you need to use migrations in the meantime revert to beta.4.

@MGatner
Copy link
Member

MGatner commented Aug 30, 2019

New migration logic is in place. Please update to the latest develop branch and try it again!

@MGatner
Copy link
Member

MGatner commented Aug 30, 2019

#2137

@muradmustafayev
Copy link
Author

muradmustafayev commented Aug 31, 2019 •
edited
Loading

This weekend will give it a shot, thanks

@jim-parry jim-parry added the waiting for info Issues or pull requests that need further clarification from the author label Sep 1, 2019
@Martin-4Spaces
Copy link

Rollback or to be exact MigrationRunner::regress will always run down in an ascending order which causes problems. Migrations should always run ascending up and descending down.
Please take a look at it. Thank you.

@MGatner
Copy link
Member

MGatner commented Sep 5, 2019

You are so right. Fix incoming.

@MGatner MGatner mentioned this issue Sep 5, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lonnieezell @jim-parry @Martin-4Spaces @MGatner @muradmustafayev