Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseBuilder::get() resets query even if reset = false #2141

Closed
tangix opened this issue Aug 13, 2019 · 0 comments · Fixed by #2142
Closed

BaseBuilder::get() resets query even if reset = false #2141

tangix opened this issue Aug 13, 2019 · 0 comments · Fixed by #2142

Comments

@tangix
Copy link
Contributor

tangix commented Aug 13, 2019

Describe the bug
When calling BaseBuilder::get() with parameters to return the SQL but not reset the state of the builder, the builder is reset anyway.

CodeIgniter 4 version
4.0.0-beta4

Affected module(s)
Database\Builder

Expected behavior, and steps to reproduce if appropriate
When returning the SQL and setting reset = false, the builder should not be reset.

Context
PHP 7.2.21 and 7.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant