Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography Helper #214

Closed
8 tasks
lonnieezell opened this issue Aug 2, 2016 · 3 comments
Closed
8 tasks

Typography Helper #214

lonnieezell opened this issue Aug 2, 2016 · 3 comments
Labels
in progress new feature PRs for new features
Milestone

Comments

@lonnieezell
Copy link
Member

Port the existing helper over.

Development Checklist:

  • Component(s)
  • ... with PHPdocs
  • Unit testing
  • ... with >80% coverage
  • User guide updated
  • Classmap integration?
  • Securely signed commits
  • Conforms to style guide
@lonnieezell lonnieezell added help wanted More help is needed for the proper resolution of an issue or pull request new feature PRs for new features labels Aug 2, 2016
@lonnieezell lonnieezell added this to the Pre-Alpha 2 milestone Aug 2, 2016
@Portaflex
Copy link
Contributor

In CI3 we have Typography Helper and Typography Library. The helper just loads the library for two of its functions and Security Class for entity_decode function.

Would it make sense to merge helper and library and have just a Typography class (library) with static methods, no helper needed?

@Portaflex
Copy link
Contributor

Initial pull request made. Don't know how to create tests. :-(

@lonnieezell
Copy link
Member Author

Sorry. Just now getting a chance to look at this. My initial reaction was a No to static methods, but your pull request doesn't use any, so that's all good. :)

I'll make some comments on that PR, since there's some formatting and style issues that need to be corrected, etc.

This article at SitePoint goes over the basics of using PHPUnit so that should get you started. Didn't you work with tests on the previous PR you made? Between that article and the existing tests, that should get you going, but don't hesitate to ask questions if you're unsure of something. I'll help you through it, but I'd really like to see tests with your PR's.

@lonnieezell lonnieezell added in progress and removed help wanted More help is needed for the proper resolution of an issue or pull request labels Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress new feature PRs for new features
Projects
None yet
Development

No branches or pull requests

2 participants