New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in session FileHandler and BaseHandler #152

Closed

arma7x opened this issue Jul 10, 2016 · 2 comments

Contributor

arma7x commented Jul 10, 2016

Constructor should override parent for passing config https://github.com/bcit-ci/CodeIgniter4/blob/develop/system/Session/Handlers/FileHandler.php#L80:
parent::__construct($config);
Typo in https://github.com/bcit-ci/CodeIgniter4/blob/develop/system/Session/Handlers/BaseHandler.php#L118
$this->cookieDomain = $config->cookoieDomain;

Contributor

ridho1991 commented Jul 11, 2016

I fixed $config->cookoieDomain, and pull request #153 submitted. I hope it merged soon. thx

lonnieezell closed this as completed in

184034f

Member

lonnieezell commented Jul 11, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment