Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI problem with progress complete's message #135

Closed
sayonara90s opened this issue Jun 30, 2016 · 3 comments
Closed

CLI problem with progress complete's message #135

sayonara90s opened this issue Jun 30, 2016 · 3 comments
Labels
bug Verified issues on the current code behavior or pull requests that will fix them help wanted More help is needed for the proper resolution of an issue or pull request
Milestone
Pre-Alpha 2

Comments

@sayonara90s
Copy link
Contributor

sayonara90s commented Jun 30, 2016 •
edited
Loading

CLI Progress, when it done shows message with repeated two characters from the end.

[..........] 0% Completete

Completete => .........tete

If I testing with changing the core (system/CLI/CLI.php):

Done => Donene (....nene)

looks better if I added two spaces (line 536):

fwrite(STDOUT, " {$percent}% Complete  ".PHP_EOL);

OS: Win8.1-x64 (console)
@jim-parry jim-parry added this to the Pre-Alpha 2 milestone Jun 30, 2016
@jim-parry
Copy link
Contributor

Bugfix Checklist:

  • Component(s) modified
  • Unit testing updated
  • User guide updated
  • Securely signed commits
  • Conforms to style guide

@jim-parry jim-parry added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 30, 2016
@lonnieezell lonnieezell added the help wanted More help is needed for the proper resolution of an issue or pull request label Jul 11, 2016
@davidgv88 davidgv88 mentioned this issue Sep 12, 2016
Merged
@dlaynes
Copy link

dlaynes commented Dec 21, 2016

Will the third parameter fix the issue? (Sorry for not testing this on my own)
fwrite($out, $str, strlen($str));

@takekoshinet takekoshinet mentioned this issue Dec 23, 2016
Merged
@lonnieezell
Copy link
Member

Fixed in #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them help wanted More help is needed for the proper resolution of an issue or pull request
Projects
None yet
Milestone
Pre-Alpha 2
Development

No branches or pull requests
4 participants
@lonnieezell @dlaynes @jim-parry @sayonara90s