Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP\ResponseTest Language Problem #1069

Closed
byazrail opened this issue Jun 9, 2018 · 3 comments
Closed

HTTP\ResponseTest Language Problem #1069

byazrail opened this issue Jun 9, 2018 · 3 comments
Assignees

Comments

@byazrail
Copy link
Contributor

byazrail commented Jun 9, 2018

  1. CodeIgniter\HTTP\ResponseTest::testRequiresMessageWithUnknownStatusCode
    Failed asserting that exception message 'HTTP.unknownStatusCode' contains 'Unknown HTTP status code provided with no message'.

./phpunit tests/system/HTTP/

fix;
public function testRequiresMessageWithUnknownStatusCode()
{
$response = new Response(new App());

	$this->expectException(HTTPException::class);
	$this->expectExceptionMessage(lang('HTTP.unknownStatusCode', [115]));
	$response->setStatusCode(115);
}
@jim-parry
Copy link
Contributor

Good catch, thanks. I will fix that with my next sweep of the HTTP testing.

@byazrail
Copy link
Contributor Author

byazrail commented Jun 9, 2018

No problem, happy coding :)

@byazrail
Copy link
Contributor Author

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants