Merge branch 'develop' of https://github.com/codeigniter4/CodeIgniter4 …

…into common-docs

app/Common.php

@@ -0,0 +1,15 @@
+<?php
+
+/**
+ * The goal of this file is to allow developers a location
+ * where they can overwrite core procedural functions and
+ * replace them with their own. This file is loaded during
+ * the bootstrap process and is called during the frameworks
+ * execution.
+ *
+ * This can be looked at as a `master helper` file that is
+ * loaded early on, and may also contain additional functions
+ * that you'd like to use throughout your entire application
+ *
+ * @link: https://codeigniter4.github.io/CodeIgniter4/
+ */

spark

@@ -53,5 +53,9 @@ ini_set('display_errors', 1);
 // Show basic information before we do anything else.
 $console->showHeader();
 
-// fire off the command the main framework.
-$console->run();
+// fire off the command in the main framework.
+$response = $console->run();
+if ($response->getStatusCode() >= 300)
+{
+	exit($response->getStatusCode());
+}

system/Autoloader/FileLocator.php

@@ -126,19 +126,19 @@ public function locateFile(string $file, string $folder = null, string $ext = 'p
 			$filename = implode('/', $segments);
 			break;
 		}
-		
+
 		// if no namespaces matched then quit
 		if (empty($paths))
 		{
 			return false;
 		}
-		
+
 		// Check each path in the namespace
 		foreach ($paths as $path)
 		{
 			// Ensure trailing slash
 			$path = rtrim($path, '/') . '/';
-			
+
 			// If we have a folder name, then the calling function
 			// expects this file to be within that folder, like 'Views',
 			// or 'libraries'.
@@ -153,7 +153,7 @@ public function locateFile(string $file, string $folder = null, string $ext = 'p
 				return $path;
 			}
 		}
-		
+
 		return false;
 	}
 

system/CLI/CommandRunner.php

@@ -71,6 +71,7 @@ class CommandRunner extends Controller
 	 * @param string $method
 	 * @param array  ...$params
 	 *
+	 * @return mixed
 	 * @throws \ReflectionException
 	 */
 	public function _remap($method, ...$params)
@@ -81,7 +82,7 @@ public function _remap($method, ...$params)
 			array_shift($params);
 		}
 
-		$this->index($params);
+		return $this->index($params);
 	}
 
 	//--------------------------------------------------------------------

system/CodeIgniter.php

@@ -355,6 +355,12 @@ protected function handleRequest(RouteCollectionInterface $routes = null, $cache
 		else
 		{
 			$response = $this->response;
+
+			// Set response code for CLI command failures
+			if (is_numeric($returned) || $returned === false)
+			{
+				$response->setStatusCode(400);
+			}
 		}
 
 		if ($response instanceof Response)

system/Commands/Database/CreateMigration.php

@@ -123,7 +123,7 @@ public function run(array $params = [])
 
 		if (! empty($ns))
 		{
-			// Get all namespaces form  PSR4 paths.
+			// Get all namespaces from PSR4 paths.
 			$config     = new Autoload();
 			$namespaces = $config->psr4;
 

system/Commands/Database/MigrateLatest.php → system/Commands/Database/Migrate.php

@@ -43,11 +43,11 @@
 use Config\Services;
 
 /**
- * Creates a new migration file.
+ * Runs all new migrations.
  *
  * @package CodeIgniter\Commands
  */
-class MigrateLatest extends BaseCommand
+class Migrate extends BaseCommand
 {
 	/**
 	 * The group the command is lumped under
@@ -69,7 +69,7 @@ class MigrateLatest extends BaseCommand
 	 *
 	 * @var string
 	 */
-	protected $description = 'Migrates the database to the latest schema.';
+	protected $description = 'Locates and runs all new migrations against the database.';
 
 	/**
 	 * the Command's usage
@@ -93,7 +93,7 @@ class MigrateLatest extends BaseCommand
 	protected $options = [
 		'-n'   => 'Set migration namespace',
 		'-g'   => 'Set database group',
-		'-all' => 'Set latest for all namespace, will ignore (-n) option',
+		'-all' => 'Set for all namespaces, will ignore (-n) option',
 	];
 
 	/**
@@ -104,22 +104,31 @@ class MigrateLatest extends BaseCommand
 	public function run(array $params = [])
 	{
 		$runner = Services::migrations();
+		$runner->clearCliMessages();
 
-		CLI::write(lang('Migrations.toLatest'), 'yellow');
+		CLI::write(lang('Migrations.latest'), 'yellow');
 
 		$namespace = $params['-n'] ?? CLI::getOption('n');
 		$group     = $params['-g'] ?? CLI::getOption('g');
 
 		try
 		{
+			// Check for 'all' namespaces
 			if ($this->isAllNamespace($params))
 			{
-				$runner->latestAll($group);
+				$runner->setNamespace(null);
 			}
-			else
+			// Check for a specified namespace
+			elseif ($namespace)
 			{
-				$runner->latest($namespace, $group);
+				$runner->setNamespace($namespace);
 			}
+
+			if (! $runner->latest($group))
+			{
+				CLI::write(lang('Migrations.generalFault'), 'red');
+			}
+
 			$messages = $runner->getCliMessages();
 			foreach ($messages as $message)
 			{

system/Commands/Database/MigrateRefresh.php

@@ -104,7 +104,7 @@ class MigrateRefresh extends BaseCommand
 	 */
 	public function run(array $params = [])
 	{
-		$this->call('migrate:rollback', ['-b' => 1]);
+		$this->call('migrate:rollback', ['-b' => 0]);
 		$this->call('migrate');
 	}
 

system/Commands/Database/MigrateRollback.php

@@ -72,7 +72,7 @@ class MigrateRollback extends BaseCommand
 	 *
 	 * @var string
 	 */
-	protected $description = 'Runs the down method for all migrations in the last batch.';
+	protected $description = 'Runs the "down" method for all migrations in the last batch.';
 
 	/**
 	 * the Command's usage
@@ -94,7 +94,7 @@ class MigrateRollback extends BaseCommand
 	 * @var array
 	 */
 	protected $options = [
-		'-b' => 'Specify a batch to roll back to',
+		'-b' => 'Specify a batch to roll back to; e.g. "3" to return to batch #3 or "-2" to roll back twice',
 		'-g' => 'Set database group',
 	];
 
@@ -108,8 +108,6 @@ public function run(array $params = [])
 	{
 		$runner = Services::migrations();
 
-		CLI::write(lang('Migrations.rollingBack'), 'yellow');
-
 		$group = $params['-g'] ?? CLI::getOption('g');
 
 		if (! is_null($group))
@@ -119,10 +117,14 @@ public function run(array $params = [])
 
 		try
 		{
-			$batch = $params['-b'] ?? $runner->getLastBatch();
-
-			$runner->version($runner->getBatchStart($batch));
-
+			$batch = $params['-b'] ?? CLI::getOption('b') ?? $runner->getLastBatch() - 1;
+			CLI::write(lang('Migrations.rollingBack') . ' ' . $batch, 'yellow');
+
+			if (! $runner->regress($batch))
+			{
+				CLI::write(lang('Migrations.generalFault'), 'red');
+			}
+
 			$messages = $runner->getCliMessages();
 			foreach ($messages as $message)
 			{

system/Commands/Database/MigrateStatus.php

@@ -160,17 +160,18 @@ public function run(array $params = [])
 
 			CLI::write('  ' . str_pad(lang('Migrations.filename'), $max + 4) . lang('Migrations.on'), 'yellow');
 
-			foreach ($migrations as $version => $migration)
+			foreach ($migrations as $uid => $migration)
 			{
 				$date = '';
 				foreach ($history as $row)
 				{
-					if ($row['version'] !== $version)
+
+					if ($runner->getObjectUid($row) !== $uid)
 					{
 						continue;
 					}
 
-					$date = date('Y-m-d H:i:s', $row['time']);
+					$date = date('Y-m-d H:i:s', $row->time);
 				}
 				CLI::write(str_pad('  ' . $migration->name, $max + 6) . ($date ? $date : '---'));
 			}