From b1872416081e0cacad6c6043017dd43d17e16edf Mon Sep 17 00:00:00 2001 From: Sandstrom <1013635+tangix@users.noreply.github.com> Date: Thu, 16 Jul 2020 21:09:19 +0200 Subject: [PATCH 1/2] Added clear upgrade instructions to 4.0.4 --- .../source/installation/upgrade_404.rst | 19 +++++++++++++++++++ .../source/installation/upgrading.rst | 5 +++-- 2 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 user_guide_src/source/installation/upgrade_404.rst diff --git a/user_guide_src/source/installation/upgrade_404.rst b/user_guide_src/source/installation/upgrade_404.rst new file mode 100644 index 000000000000..97e2ec26c250 --- /dev/null +++ b/user_guide_src/source/installation/upgrade_404.rst @@ -0,0 +1,19 @@ +############################# +Upgrading from 4.0.x to 4.0.4 +############################# + +CodeIgniter 4.0.4 fixes a bug in the implementation of Controller Filter, breaking +code implementing the ``FilterInterface``. + +**Update FilterInterface declarations** + +The method signatures for ``after()`` and ``before()`` need to be update to include ``$arguments``. The function +definitions should be changed from:: + + public function before(RequestInterface $request) + public function after(RequestInterface $request, ResponseInterface $response) + +to:: + + public function before(RequestInterface $request, $arguments = null) + public function after(RequestInterface $request, ResponseInterface $response, $arguments = null) diff --git a/user_guide_src/source/installation/upgrading.rst b/user_guide_src/source/installation/upgrading.rst index c271e0c90dea..1e0e8121edc4 100644 --- a/user_guide_src/source/installation/upgrading.rst +++ b/user_guide_src/source/installation/upgrading.rst @@ -6,6 +6,7 @@ Please read the upgrade notes corresponding to the version you are upgrading from. .. toctree:: - :titlesonly: + :titlesonly: - Upgrading from 3.x to 4.x \ No newline at end of file + Upgrading from 4.0.x to 4.0.4 + Upgrading from 3.x to 4.x From 96f70706e48791ef53196fba2ac65d12d53557bd Mon Sep 17 00:00:00 2001 From: Sandstrom <1013635+tangix@users.noreply.github.com> Date: Fri, 17 Jul 2020 07:51:14 +0200 Subject: [PATCH 2/2] Fixed spelling and added link to Controller Filters page. --- user_guide_src/source/installation/upgrade_404.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/user_guide_src/source/installation/upgrade_404.rst b/user_guide_src/source/installation/upgrade_404.rst index 97e2ec26c250..8703e3bd6680 100644 --- a/user_guide_src/source/installation/upgrade_404.rst +++ b/user_guide_src/source/installation/upgrade_404.rst @@ -2,12 +2,12 @@ Upgrading from 4.0.x to 4.0.4 ############################# -CodeIgniter 4.0.4 fixes a bug in the implementation of Controller Filter, breaking +CodeIgniter 4.0.4 fixes a bug in the implementation of :doc:`Controller Filters `, breaking code implementing the ``FilterInterface``. **Update FilterInterface declarations** -The method signatures for ``after()`` and ``before()`` need to be update to include ``$arguments``. The function +The method signatures for ``after()`` and ``before()`` must be updated to include ``$arguments``. The function definitions should be changed from:: public function before(RequestInterface $request) @@ -17,3 +17,4 @@ to:: public function before(RequestInterface $request, $arguments = null) public function after(RequestInterface $request, ResponseInterface $response, $arguments = null) +