From 1c5ff8ddcb8a8ba6e5fd73eebb4dbd5b2804a7c1 Mon Sep 17 00:00:00 2001 From: kenjis Date: Tue, 26 Sep 2023 07:00:24 +0900 Subject: [PATCH 1/2] docs: make public properties deprecated No need to be public. --- system/CLI/CLI.php | 4 ++++ user_guide_src/source/changelogs/v4.4.2.rst | 2 ++ 2 files changed, 6 insertions(+) diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php index 29f424d1ec53..4974d0ae48f2 100644 --- a/system/CLI/CLI.php +++ b/system/CLI/CLI.php @@ -42,6 +42,8 @@ class CLI * Is the readline library on the system? * * @var bool + * + * @deprecated 4.4.2 Should be protected. */ public static $readline_support = false; @@ -49,6 +51,8 @@ class CLI * The message displayed at prompts. * * @var string + * + * @deprecated 4.4.2 Should be protected. */ public static $wait_msg = 'Press any key to continue...'; diff --git a/user_guide_src/source/changelogs/v4.4.2.rst b/user_guide_src/source/changelogs/v4.4.2.rst index c956964fa9ea..55cf33b0df25 100644 --- a/user_guide_src/source/changelogs/v4.4.2.rst +++ b/user_guide_src/source/changelogs/v4.4.2.rst @@ -32,6 +32,8 @@ Deprecations - **Filters:** The Auto-Discovery for Filters and ``Filters::discoverFilters()`` is deprecated. Use :ref:`registrars` instead. See :ref:`modules-filters` for details. +- **CLI:** The public property ``CLI::$readline_support`` and ``CLI::$wait_msg`` + are deprecated. These methods will be protected. Bugs Fixed ********** From dc84d18e1e53a6b41d887d773b2a27ade189e89b Mon Sep 17 00:00:00 2001 From: kenjis Date: Wed, 11 Oct 2023 06:09:24 +0900 Subject: [PATCH 2/2] docs: add @TODO to rename --- system/CLI/CLI.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php index 4974d0ae48f2..b93d0eb50f11 100644 --- a/system/CLI/CLI.php +++ b/system/CLI/CLI.php @@ -44,6 +44,7 @@ class CLI * @var bool * * @deprecated 4.4.2 Should be protected. + * @TODO Fix to camelCase in the next major version. */ public static $readline_support = false; @@ -53,6 +54,7 @@ class CLI * @var string * * @deprecated 4.4.2 Should be protected. + * @TODO Fix to camelCase in the next major version. */ public static $wait_msg = 'Press any key to continue...'; @@ -67,6 +69,8 @@ class CLI * Foreground color list * * @var array + * + * @TODO Fix to camelCase in the next major version. */ protected static $foreground_colors = [ 'black' => '0;30', @@ -92,6 +96,8 @@ class CLI * Background color list * * @var array + * + * @TODO Fix to camelCase in the next major version. */ protected static $background_colors = [ 'black' => '40',