Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on section in caller workflows #14

Closed
4 tasks done
Tracked by #7819
kenjis opened this issue Sep 11, 2023 · 1 comment
Closed
4 tasks done
Tracked by #7819

Fix on section in caller workflows #14

kenjis opened this issue Sep 11, 2023 · 1 comment
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@kenjis
Copy link
Member

kenjis commented Sep 11, 2023

The on.pull_request and on.push in called workflow do not work. See codeigniter4/shield#819
We need to move them to caller workflows.

on:
pull_request:
branches:
- develop
paths:
- '**.php'
- 'composer.*'
- 'depfile.yaml'
- '.github/workflows/deptrac.yml'
push:
branches:
- develop
paths:
- '**.php'
- 'composer.*'
- 'depfile.yaml'
- '.github/workflows/deptrac.yml'

@MGatner
Copy link
Member

MGatner commented Sep 12, 2023

That's unfortunate because it is a significant amount of duplication. It does make sense though, and prevents security issues.

@kenjis kenjis closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

2 participants