Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading SP certificate from file #89

Open
qwertz182 opened this issue Mar 31, 2022 · 2 comments
Open

Loading SP certificate from file #89

qwertz182 opened this issue Mar 31, 2022 · 2 comments

Comments

@qwertz182
Copy link
Contributor

If 'samlidp.encrypt_assertion' is set to true, the SP certificate is needed.
It would be great if it was possible to add it from a file instead of placing that long ugly certificate string inside the .env file.

In the package "aacotroneo/laravel-saml2" this is done in the config by adding a prefix like this:

'x509cert' => 'file://' . storage_path('samlsp/cert.pem'),

As far as I could see in the code, the LightSaml package offers a loadFromFile() method in the X509Certificate class.

Regards,

@upwebdesign
Copy link
Contributor

@as-dialoggroup nice suggestion. Yes, I like this idea. Time is sparse these days, so I will mark this as an enhancement. In the meantime, if you have some time to create a PR, I would make the time to review it. If not thats cool. Thanks for sharing your idea!

@qwertz182
Copy link
Contributor Author

I guess I could do that. Can't guarantee it the next days, but I'd be happy to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants