Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 upgrade throws kernel error for the overwritten each method #232

Open
kajatiger opened this issue Jan 12, 2022 · 4 comments
Open

Comments

@kajatiger
Copy link

🐞 Bug Report

Steps to reproduce

We have an item that is the first hyperlink to the actual media and need to iterate through the sub nodes of it:

item.sub_nodes.map(&:name).to_s

And then we get an error saying

SystemStackError:
        stack level too deep

since upgrading the rails app to ruby 3 (and rails 6.1)

Expected behavior

We would expect to get a string back that contains the name of each item sub node.

Possible Solution

We don't exactly have a solution, but suppose the answer would be somewhere in the definition of the each block here:

def each(&block)

@dblock
Copy link
Collaborator

dblock commented Jan 12, 2022

Start by adding Ruby 3 to https://github.com/codegram/hyperclient/blob/master/.travis.yml, do we have a repro of this out of the box with existing specs? If not, try building a repro?

@kajatiger
Copy link
Author

We fixed this in one spot now with adding embedded:
https://github.com/artsy/impulse/pull/805#discussion_r783322301

@dblock
Copy link
Collaborator

dblock commented Jan 13, 2022

We fixed this in one spot now with adding embedded: https://github.com/artsy/impulse/pull/805#discussion_r783322301

Looks like impulse is a private repo @kajatiger.

@dblock
Copy link
Collaborator

dblock commented Feb 16, 2023

I fixed CI/CD with GHA on this repo and added Ruby 3.2 without issues. Interested in taking this on @kajatiger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants