add dark mode styling #2138

rohitpaulk · 2024-08-23T12:18:07Z

Refactor vote page components from JS to TS for better type safety and clarity.
Refactor components to improve TypeScript compatibility and update dependencies.
Refactor header component by removing unused type imports and comments.
Remove duplicate dependency for @glint/environment-ember-template-imports.
update invert styling

Summary by CodeRabbit

New Features
- Enhanced visual feedback in the voting system with dynamic border styles based on user voting status.
- Improved text and button visibility in dark mode across various components.
Bug Fixes
- Resolved inconsistencies in text visibility and button styles in dark mode.
Chores
- Removed the 'blue-invert' theme configuration for a more streamlined color palette.
- Standardized class usage for improved consistency in component styling.

coderabbitai · 2024-08-23T12:18:17Z

Walkthrough

The recent changes involve modifications to the HTML structure and class assignments across various components, enhancing support for dark mode and improving visual feedback based on user interactions. Additionally, the tailwind.config.js file saw the removal of the 'blue-invert' theme configuration, with new properties added under the 'green' theme.

Changes

Files	Change Summary
`app/components/private-leaderboard-feature-suggestion.hbs`, `app/components/vote-page/course-extension-idea-card.hbs`, `app/components/vote-page/idea-card/vote-button.gts`, `app/components/product-walkthrough-feature-suggestion.hbs`, `app/components/course-page/completed-step-notice.hbs`, `app/components/course-page/course-stage-step/feedback-prompt.hbs`	Adjustments to class names and conditional logic for styling based on user actions, enhancing dark mode support.
`tailwind.config.js`	Removal of the `'blue-invert'` theme configuration and addition of new properties under the `'green'` theme.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Component
    User->>Component: Interacts with voting functionality
    Component-->>User: Displays updated visual feedback (style changes)

🐰 In the meadow, where the colors blend,
A button glows, on votes we depend.
With styles that shift from dark to light,
Our choices shine, oh what a sight!
The blue has faded, green takes the lead,
In this world of change, we happily proceed! 🌈

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-08-23T12:21:22Z

Test Results

1 files ±0 1 suites ±0 7m 20s ⏱️ + 1m 10s
567 tests ±0 531 ✅ ±0 36 💤 ±0 0 ❌ ±0
582 runs ±0 546 ✅ ±0 36 💤 ±0 0 ❌ ±0

Results for commit 90247c1. ± Comparison against base commit 9d1a45b.

♻️ This comment has been updated with latest results.

codecov · 2024-08-23T12:21:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

📢 Thoughts on this report? Let us know!

codecov · 2024-08-23T12:21:56Z

Bundle Report

Changes will increase total bundle size by 1.92kB ⬆️

Bundle name	Size	Change
client-array-push	35.36MB	1.92kB ⬆️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9d1a45b and 1af9cb0.

Files selected for processing (4)

app/components/private-leaderboard-feature-suggestion.hbs (1 hunks)
app/components/vote-page/course-extension-idea-card.hbs (1 hunks)
app/components/vote-page/idea-card/vote-button.gts (1 hunks)
tailwind.config.js (1 hunks)

Files skipped from review due to trivial changes (2)

app/components/private-leaderboard-feature-suggestion.hbs
tailwind.config.js

Additional comments not posted (4)

app/components/vote-page/idea-card/vote-button.gts (2)

31-35: Dark mode styling logic is correct.

The conditional class assignment for the button's border color correctly includes dark mode variants.

42-42: Dark mode text color logic is correct.

The conditional class assignment for the text span correctly includes dark mode text color for visibility.

app/components/vote-page/course-extension-idea-card.hbs (2)

2-3: Dark mode border styling logic is correct.

The conditional class assignment for the outer <div> correctly includes dark mode border styles.

9-9: Dark mode text color logic is correct.

The text color for the inner <div> correctly includes dark mode styling for visibility.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1af9cb0 and 44cd155.

Files selected for processing (2)

app/components/product-walkthrough-feature-suggestion.hbs (1 hunks)
tailwind.config.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

tailwind.config.js

Additional comments not posted (2)

app/components/product-walkthrough-feature-suggestion.hbs (2)

4-4: Semantic enhancement with <b> element.

The replacement of <span> with <b> improves the semantic meaning of the text, aligning with best practices for accessibility.

11-11: Dark mode styling enhancement for dismiss button.

The addition of dark mode styles ensures the button's appearance is consistent with the theme, improving user experience.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 44cd155 and 6125204.

Files selected for processing (2)

app/components/product-walkthrough-feature-suggestion.hbs (1 hunks)
tailwind.config.js (1 hunks)

Files skipped from review as they are similar to previous changes (2)

app/components/product-walkthrough-feature-suggestion.hbs
tailwind.config.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6125204 and 7572b66.

Files selected for processing (2)

app/components/course-page/completed-step-notice.hbs (2 hunks)
app/components/course-page/course-stage-step/feedback-prompt.hbs (3 hunks)

Files skipped from review due to trivial changes (2)

app/components/course-page/completed-step-notice.hbs
app/components/course-page/course-stage-step/feedback-prompt.hbs

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7572b66 and 90247c1.

Files selected for processing (1)

app/components/course-page/course-stage-step/feedback-prompt.hbs (3 hunks)

Files skipped from review due to trivial changes (1)

app/components/course-page/course-stage-step/feedback-prompt.hbs

update invert styling

1af9cb0

vercel bot deployed to Preview – frontend August 23, 2024 12:21 View deployment

vercel bot deployed to Preview – frontend-stg August 23, 2024 12:21 View deployment

coderabbitai bot reviewed Aug 23, 2024

View reviewed changes

vercel bot deployed to Preview – frontend August 23, 2024 12:25 View deployment

vercel bot deployed to Preview – frontend-stg August 23, 2024 12:26 View deployment

coderabbitai bot reviewed Aug 23, 2024

View reviewed changes

update green color handling [percy]

6125204

rohitpaulk force-pushed the add-dark-mode-styling branch from 44cd155 to 6125204 Compare August 23, 2024 12:46

vercel bot deployed to Preview – frontend August 23, 2024 12:49 View deployment

vercel bot deployed to Preview – frontend-stg August 23, 2024 12:50 View deployment

coderabbitai bot reviewed Aug 23, 2024

View reviewed changes

update [percy]

7572b66

vercel bot deployed to Preview – frontend August 23, 2024 13:12 View deployment

coderabbitai bot reviewed Aug 23, 2024

View reviewed changes

vercel bot deployed to Preview – frontend-stg August 23, 2024 13:13 View deployment

update [percy]

90247c1

vercel bot deployed to Preview – frontend August 23, 2024 13:49 View deployment

coderabbitai bot reviewed Aug 23, 2024

View reviewed changes

rohitpaulk merged commit 45a7b66 into main Aug 23, 2024
4 of 6 checks passed

rohitpaulk deleted the add-dark-mode-styling branch August 23, 2024 13:50

vercel bot deployed to Preview – frontend-stg August 23, 2024 13:50 View deployment

This was referenced Sep 24, 2024

Remove unnecessary glint-ignore comments from concept-progress and language-guide-card. #2247

Merged

Use CodeMirror on Admin Submissions Diff tab #2204

Merged

More consistency for dark mode colors #2268

Merged

coderabbitai bot mentioned this pull request Oct 17, 2024

Only show previous steps incomplete modal for instructions & setup #2331

Merged

coderabbitai bot mentioned this pull request Oct 18, 2024

Clearer handling of expandable list steps #2333

Merged

coderabbitai bot mentioned this pull request Oct 25, 2024

Refactor contest navigation to use navigable contests and add slugPrefix getter. #2363

Merged

This was referenced Nov 13, 2024

delete repository inline #2396

Merged

Tweak 2nd stage instructions for the Solution experiment #2407

Merged

coderabbitai bot mentioned this pull request Nov 23, 2024

mellow grays #2424

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add dark mode styling #2138

add dark mode styling #2138

rohitpaulk commented Aug 23, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 23, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 23, 2024 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

add dark mode styling #2138

add dark mode styling #2138

Conversation

rohitpaulk commented Aug 23, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Aug 23, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Aug 23, 2024 • edited Loading

Test Results

codecov bot commented Aug 23, 2024 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2024 • edited Loading

Bundle Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

rohitpaulk commented Aug 23, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 23, 2024 •

edited

Loading