-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added codecov.io tests via JUnit tests conversion #36
Open
nikolaydubina
wants to merge
6
commits into
codecov:main
Choose a base branch
from
nikolaydubina:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaydubina
commented
Aug 22, 2024
nikolaydubina
commented
Aug 22, 2024
nikolaydubina
commented
Aug 22, 2024
nikolaydubina
commented
Aug 22, 2024
nikolaydubina
commented
Aug 22, 2024
nikolaydubina
commented
Aug 22, 2024
cc: @jstemmer |
@nikolaydubina thanks for this. I don't think we can merge this in as this has more functionality than we are expecting users when starting off using Codecov. However, there might be something here with test results. I'm going to cc @rohan-at-sentry who might find this interesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You guys are amazing! I have been long time advocate and implemented myself similar systems for Continuous Tests Monitoring as you guys just recently published. I already migrated all my open source Go projects (20+) to this setup and published how-to article in go-recipes (so expect more people will start using it soon! hehe).
Here I wanted to show how to do it in official example.
On choice of JUnit tests converter
gotestsum
, it is widely used tool, but it is too big, it does other things too. it also requires non-github path for module, which raises eyebrows a little in open source Go community.go-junit-report
is developed by a guy from Google, which is nice. it is also very small and does one thing only for JUnit conversion, which is in spirit of UNIX philosophy. it also does not require any dependencies. so it is winner for me, albeit I mention other tool too in guide.as for requests:
Thanks again! Nice work!