This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 139
Added option to disable printing of gcov-out #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=====================================
Coverage 88% 88%
=====================================
Files 2 2
Lines 9 9
=====================================
Hits 8 8
Misses 1 1 |
@thomasrockhu it would be great to get this feature into a release. At work we have a large project with many sources files and the build logs get full easily with the gcov output. Thanks in advance! |
thomasrockhu
reviewed
Dec 6, 2020
codecov/__init__.py
Outdated
Comment on lines
988
to
989
if codecov.gcov_out: | ||
write(" Executing gcov (%s)" % cmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should write this regardless
Suggested change
if codecov.gcov_out: | |
write(" Executing gcov (%s)" % cmd) | |
write(" Executing gcov (%s)" % cmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasrockhu I have made some of the requested changes. |
thomasrockhu
approved these changes
Dec 10, 2020
Thanks! |
With this PR our coverage build logs went from 426KB to 114KB. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the same option by the same name in the bash uploader. Any errors written out to
stderr
bygcov
will still be output in thePopen
call. This PR should also help with #168.