fix: add in all the extra arguments for uploader #955

thomasrockhu-codecov · 2023-04-11T04:58:15Z

No description provided.

codecov · 2023-04-11T04:58:39Z

Codecov Report

Merging #955 (d1bda53) into main (91e1847) will increase coverage by 1.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
+ Coverage   95.32%   96.35%   +1.03%     
==========================================
  Files           4        4              
  Lines         171      192      +21     
  Branches       49       56       +7     
==========================================
+ Hits          163      185      +22     
+ Misses          8        7       -1

Flag	Coverage Δ
demo	`80.00% <ø> (ø)`
macos-latest	`96.35% <100.00%> (+1.03%)`	⬆️
script	`97.74% <100.00%> (+0.94%)`	⬆️
ubuntu-latest	`96.35% <100.00%> (+1.03%)`	⬆️
version	`80.00% <ø> (ø)`
windows-latest	`96.35% <100.00%> (+1.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/buildExec.ts	`99.30% <100.00%> (+0.94%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

3flex · 2023-04-12T23:49:28Z

README.md

@@ -35,7 +35,7 @@ steps:
 - uses: actions/checkout@master
 - uses: codecov/codecov-action@v3
  with:
-    token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos


Is this a breaking change? Is it now required for public repos?

@3flex this is not a breaking change, but we do suggest using the token when possible to prevent flakiness when hitting the GitHub API

kleisauke · 2023-04-29T20:01:40Z

src/buildExec.ts

  }
  if (gcovIgnore) {
-    execArgs.push('--gcovIgnore', `${gcovIgnore}`);
+    execArgs.push('-gcovIgnore', `${gcovIgnore}`);


This change is incorrect and causes files/directories listed in gcov_ignore to be included (i.e. the whole option is ignored since version 3.1.2).

Only short CLI option names can be specified with a single dash (-) instead of 2 (--), see:
https://github.com/codecov/uploader/blob/cb97e5f75b4bba3afed0b07380d5ab29c34d66be/HELPFILE#L40-L42
https://github.com/codecov/uploader/blob/cb97e5f75b4bba3afed0b07380d5ab29c34d66be/src/helpers/cli.ts#L80-L97

So to fix this, one must specify -gi or --gcovIgnore here.

FWIW, -gcovArgs, -gcovInclude, -gcovExecutable, -networkFilter, -networkPrefix are probably having the same issue.

So to fix this, one must specify -gi or --gcovIgnore here.

Ah, -gi is also invalid, a single dash is only valid for single character aliases, see:
yargs/yargs#1781 (comment)

So, this issue affects the following settings:

full_report, uses -full, needs to be changed to --full or --fullReport;

gcov_args, uses -gcovArgs, needs to be changed to --ga or --gcovArgs;

gcov_ignore, uses -gcovIgnore, needs to be changed to --gi or --gcovIgnore;

gcov_include, uses -gcovInclude, needs to be changed to --gI or --gcovInclude;

gcov_executable, uses -gcovExecutable, needs to be changed to --gx or --gcovExecutable;

network_filter, uses -networkFilter, needs to be changed to -i or --networkFilter;

networkPrefix, uses -networkPrefix, needs to be changed to -k or --networkPrefix;

swift, uses -xs, needs to be changed to --xs or --swift;

swift_project, uses -xsp, needs to be changed to --xsp or --swiftProject;

xcode, uses -xc, needs to be changed to --xc or --xcode;

xcode, uses -xp, needs to be changed to --xp or --xcodeArchivePath.

I just opened PR #969 for this.

It's recommended now to set a token for uploading the report to codecov.io as per codecov/codecov-action#955 Also set fail_ci_if_error to 'true' as this action should be stable now. Signed-off-by: Arik Hadas <[email protected]>

fix: add in all the extra arguments for uploader

d1bda53

drazisil-codecov approved these changes Apr 11, 2023

View reviewed changes

thomasrockhu-codecov merged commit 030a000 into main Apr 11, 2023

thomasrockhu-codecov deleted the update-action branch April 11, 2023 16:07

3flex reviewed Apr 12, 2023

View reviewed changes

kleisauke reviewed Apr 29, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add in all the extra arguments for uploader #955

fix: add in all the extra arguments for uploader #955

thomasrockhu-codecov commented Apr 11, 2023

codecov bot commented Apr 11, 2023 •

edited

Loading

3flex Apr 12, 2023

thomasrockhu-codecov Apr 14, 2023

kleisauke Apr 29, 2023

kleisauke Apr 30, 2023 •

edited

Loading

fix: add in all the extra arguments for uploader #955

fix: add in all the extra arguments for uploader #955

Conversation

thomasrockhu-codecov commented Apr 11, 2023

codecov bot commented Apr 11, 2023 • edited Loading

Codecov Report

3flex Apr 12, 2023

Choose a reason for hiding this comment

thomasrockhu-codecov Apr 14, 2023

Choose a reason for hiding this comment

kleisauke Apr 29, 2023

Choose a reason for hiding this comment

kleisauke Apr 30, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Apr 11, 2023 •

edited

Loading

kleisauke Apr 30, 2023 •

edited

Loading