Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash throws syntax error if inputs.token contains a newline character #1694

Closed
CarlosNihelton opened this issue Nov 21, 2024 · 5 comments · Fixed by #1721
Closed

Bash throws syntax error if inputs.token contains a newline character #1694

CarlosNihelton opened this issue Nov 21, 2024 · 5 comments · Fixed by #1721
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@CarlosNihelton
Copy link

095cfe0#r149353612

With quotes around ${{ inputs.token }} a newline shouldn't be a problem for bash as it would be seen as part of the argument string, giving tr a chance to strip it.

The screenshot below shows the error I'm seeing.

Image

@thomasrockhu-codecov thomasrockhu-codecov added bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months Area: Report Upload Issues with pre-ingest report uploading labels Nov 21, 2024
@thomasrockhu-codecov
Copy link
Contributor

@CarlosNihelton I suppose the workaround right now is to remove the newline from the token.

That said, yeah I'll work on a fix for this now!

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Nov 21, 2024
@thomasrockhu-codecov
Copy link
Contributor

@CarlosNihelton apologies, I won't be able to get a fix out for this until December. Are you blocked on this right now?

@CarlosNihelton
Copy link
Author

@CarlosNihelton apologies, I won't be able to get a fix out for this until December. Are you blocked on this right now?

Thanks for the attention. I'm not exactly blocked, as I can still use version 4 of the action as well as trimming the token. I only considered important reporting the issue because I noticed there was a commit especifically attempting to trim the newlines.

@thomasrockhu-codecov
Copy link
Contributor

@CarlosNihelton got it! I'll take a look at this after the US holiday then

@trim21
Copy link

trim21 commented Dec 3, 2024

another workaround is to use ubuntu22.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants